Hmm, i tested my PR on current codebase(staging branch), there were no problems...

Code style

FILE: ...me/travis/build/joomla/joomla-cms/layouts/joomla/content/icons/edit.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 36 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------

See https://travis-ci.org/joomla/joomla-cms/jobs/129449460#L1321

@andrepereiradasilva, Thank you! Fixed.

Can you provide testing instructions?

@memonica

1. Copy layouts/joomla/content/icons and layouts/joomla/content/icons.php to templates/protostar/html/layouts/joomla/content

2. Edit layouts

3. Go to article page and check the result.

Has anyone checked?

Hello,
I have applied this patch and overridden icons layout successfully, but encountered following issue: Language variable on hover of the icon text does not get translated as shown in the below screenshot.

I have tested this on clean copy (without any sample data) of Joomla! 3.5.1. If i remove the patch and recheck then the language variables on icons are getting translated. But if I apply the patch, then the language variables (JGLOBAL_EDIT_TITLE, JGLOBAL_EMAIL_TITLE, and JGLOBAL_PRINT_TITLE) do not get translated.

@AnishaVora Thanks for the feedback! I checked again, this problem is not found. Tested on a clean Joomla 3.5.1 installation.

@Grigory90
I have retested it on clean Joomla! 3.5.1 installation with blog sample data. When I hover over the edit icon, tool-tip is showing up properly as you have shown in the screenshot.

The language issue comes when I hover over the text ('edit', 'email' and 'print'), please see the given screenshots.

I have tested this item ✅ successfully on c87b61d

Everything works fine for me. No language issue.

I have tested this item ✅ successfully on c87b61d

Re-tested it on the Joomla! 3.6.0-rc2 and Joomla! 3.5.1 (downloaded the package again and installed) and no language issue found. I guess, there was an issue of language in the main joomla installation.

RTC

@AnishaVora Please only test against the current staging. There have been over 400 commits since Joomla 3.5.1

@brianteeman Yes, I have tested on current staging as well as on Joomla! 3.5.1 stable release.

There is no point in testing on 3.5.1 ;)

On 11 July 2016 at 09:12, Anisha Tailored notifications@github.com wrote:

@brianteeman https://github.com/brianteeman Yes, I have tested on

current staging as well as on Joomla! 3.5.1 stable release.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10423
https://issues.joomla.org/tracker/joomla-cms/10423.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10423 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8cBsWZoL09ccjLlV1W_1xg18uek8ks5qUfr8gaJpZM4IcK46
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Merged to the 3.7 branch with 60bc67b