Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10418] - [searchtools] Do not throw php notice if activeFilters is not set

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
11 May 2016

Summary of Changes

If the activeFilters object is not set in the view.html.php file, searchtools is throwing a PHP Notice.
Notice: Undefined property: InstallerViewLanguages::$activeFilters in /path/to/joomla-staging/layouts/joomla/searchtools/default.php on line 34

This PR solves that.

Testing Instructions

Mainly code review (just a isset()...).

1 But if you want to simulate the problem remove this line: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/views/languages/view.html.php#L54 (or the same line in any view) and set the error reporting to maximum.
2. Go to Extensions -> Manage -> Install Languages
3. Before patch, PHP Notice. After patch, all fine.

avatar andrepereiradasilva andrepereiradasilva - open - 11 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
Title
…
[searchtools] Do not trow php notice is activeFilters is not set
[searchtools] Do not throw php notice is activeFilters is not set
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
Title
…
[searchtools] Do not trow php notice is activeFilters is not set
[searchtools] Do not throw php notice is activeFilters is not set
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
Title
…
[searchtools] Do not throw php notice is activeFilters is not set
[searchtools] Do not throw php notice if activeFilters is not set
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
Title
…
[searchtools] Do not throw php notice is activeFilters is not set
[searchtools] Do not throw php notice if activeFilters is not set
avatar andrepereiradasilva andrepereiradasilva - change - 11 May 2016
The description was changed
avatar brianteeman brianteeman - test_item - 11 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 May 2016

I have tested this item :white_check_mark: successfully on d423869

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10418.

avatar brianteeman brianteeman - change - 11 May 2016
Category ⇒ Layout
avatar BurtNL BurtNL - test_item - 11 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 11 May 2016

I have tested this item :white_check_mark: successfully on d423869

Followed the test instructions and works as described.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10418.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 May 2016

@brianteeman @BurtNL thanks for testing!

avatar brianteeman brianteeman - change - 11 May 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 11 May 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10418.

avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 12 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-12 11:45:02
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 12 May 2016
avatar wilsonge wilsonge - merge - 12 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment