[#10400] - Trigger onContentAfterTitle event, display afterDisplayContent correct
- Fixed in Code Base
- 16 Jul 2016
- Medium
- Build: staging
- Easy Test
- # 10400
- Diff
- Digital-Peak:news-correct-events
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The Articles - Newsflash module triggers the onContentAfterDisplay event and displays the result after the title of the article. The onContentAfterTitle event result should be displayed there instead and the result from the onContentAfterDisplay event should be displayed after the intro text of the article.
This can easily be reproduced with DPAttachments as it's content plugin is only listening to the event onContentAfterDisplay as can be seen here https://github.com/Digital-Peak/DPAttachments/blob/master/plg_content_dpattachments/dpattachments.php#L21
Testing Instructions
- Create an article
- Install DPAttachments from here https://joomla.digital-peak.com/download/dpattachments
- Create an Articles - Newsflash module and publish it to position-1
- Upload an attachment trough the new module
Expected result with patch
The attachment is displayed after the description.
Result without patch
The attachment is displayed after the title, bevore the intro text, despite the onContentAfterDisplay event is triggered.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Plugins |
| Category | Plugins | ⇒ | Modules Plugins |
I have just fixed the category. Thanks. As it is both plugins and modules
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10400.
| Easy | No | ⇒ | Yes |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10400.
I have tested this item
Works as explained.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10400.
| Status | Pending | ⇒ | Ready to Commit |
@joomla-cms-bot please do your job
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10400.
| Labels |
Added:
?
|
||
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-16 06:35:21 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
The correct category for this PR is Modules and not Plugins.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10400.