? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 May 2016

Pull Request for Improvement.

Summary of Changes

In CPanel modules:

  • Adds and uniformizes tooltip (with date and hour) on dates. mod_logges, mod_latest and mod_popular.
  • Uniformizes mod_logged alignment (to be like the others).

Before
image

After
image

Testing Instructions

  1. Use joomla staging with test sample data
  2. Go to CPanel check the align and the date tooltips in the 3 modules
  3. Apply patch
  4. Go to CPanel check the align and the date tooltips in the 3 modules
avatar andrepereiradasilva andrepereiradasilva - open - 10 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ?
avatar brianteeman
brianteeman - comment - 10 May 2016

I am not in favour of this change. I find it very useful to see the time
that all my users logged in. This change makes that really hard to do on a
busy site with many logged in users

On 10 May 2016 at 12:15, andrepereiradasilva notifications@github.com
wrote:

Pull Request for Improvement.
Summary of Changes

In CPanel modules:

  • Adds and uniformizes tooltip (with date and hour) on dates. mod_logges, mod_latest and mod_popular.
  • Uniformizes mod_logged alignment (to be like the others).

Before
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15144655/c89097b8-16a8-11e6-948c-febf3b3db1c8.png

After
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15144658/cc93670a-16a8-11e6-900d-ff4290c7bcbe.png
Testing Instructions

  1. Use joomla staging with test sample data
  2. Go to CPanel check the align and the date tooltips in the 3 modules
  3. Apply patch
  4. Go to CPanel check the align and the date tooltips in the 3 modules

You can view, comment on, or merge this pull request online at:

#10382
Commit Summary

  • mod_latest: add tooltip to date
  • mod_logged: add tooltip to date
  • mod_popular: add tooltip to date

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10382

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman brianteeman - change - 10 May 2016
Category Administration Modules
avatar brianteeman
brianteeman - comment - 10 May 2016

Also this hard codes the date format which means it can not be localised

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

ok i see and understand your point. will think of a better way to achieve the goals.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

keeping this in standby.

avatar brianteeman
brianteeman - comment - 10 May 2016

I am going to close it. You can always re-open it when you have found a way to achieve your goal. Really want to stop us using the tracker as personal todo lists. It makes it hard for people to see what should be tested or now

avatar brianteeman brianteeman - change - 10 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-10 11:25:18
Closed_By brianteeman
avatar brianteeman brianteeman - close - 10 May 2016
avatar brianteeman brianteeman - close - 10 May 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

ok

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

you're right

Add a Comment

Login with GitHub to post a comment