? ? Pending
Pull Request for # 9680

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
10 May 2016

Pull Request for Issue #9680.

Summary of Changes

Sometimes when sending a testmail the mail is sent even that you know the mail config is not correct.

This happens because JMail has some fallbacks (see, for instance, https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/mail/mail.php#L601-L627).

So this PR adds a fallback warning in global configuration "Send Test Mail" button result s users can notice that the mail is sent, but not with the configurations that the user chossed.

Before PR
image

After PR
image

Testing Instructions

  1. Apply patch and go to global config
  2. Clear browser cache
  3. Test "Send Test Mail" with all possible mail configs you can remember.

I get the fallback message by using SMTP with SMTP Authentication and didn't type the SMTP Auth user or password (leave the fields empty). I this will not allow to connect to my SMTP server.
image

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar andrepereiradasilva andrepereiradasilva - open - 10 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 10 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 10 May 2016
The description was changed
avatar zero-24 zero-24 - test_item - 10 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on a90a531

Works good. please remember on testing to clear your browser cache.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar zero-24 zero-24 - change - 10 May 2016
Category Administration
avatar zero-24 zero-24 - change - 10 May 2016
Easy No Yes
avatar brianteeman brianteeman - change - 10 May 2016
Category Administration Administration Language & Strings
avatar brianteeman brianteeman - change - 10 May 2016
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

@brianteeman since you also add the original issue, can you test this one?

avatar brianteeman brianteeman - change - 10 May 2016
Rel_Number 0 9680
Relation Type Pull Request for
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 18 May 2016

@brianteeman can i ask you to please test this one?

avatar brianteeman
brianteeman - comment - 27 May 2016

I would test it if I could recreate the scenario now but i cant


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 May 2016

ok @brianteeman thanks anyway.
anyone else can test this?

avatar AnishaVora
AnishaVora - comment - 3 Jun 2016

Hello,
I have tried with incorrect SMTP details (incorrect username and password) but I could not see the same message that you have shown in before PR section. Instead I am getting 'Test mail could not be sent.' and 'SMTP Error: Could not authenticate.'

I have tested this on Joomla! 3.6.0-alpha2-dev staging.
screen shot 2016-06-03 at 08 25 28


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar gunjanpatel
gunjanpatel - comment - 3 Jun 2016

Unfortunately I am also not able to reproduce this issue before applying patch. I have followed instructions in the main issue. Like giving wrong port and wrong host but still not getting green message. Is there any other possible way to reproduce it?

Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Jun 2016

Unfortunately I am also not able to reproduce this issue before applying patch. I have followed instructions in the main issue. Like giving wrong port and wrong host but still not getting green message. Is there any other possible way to reproduce it?

Set smtp authentication to yes, with user and password empty

avatar gunjanpatel
gunjanpatel - comment - 6 Jun 2016

Thanks @andrepereiradasilva Follow your comments, but still having the same and not able to reproduce it before applying patch. I am using latest staging branch with smtp authentication to yes, with user and password empty.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jun 2016

what error do you have with the last test case? Maybe you don't have php mailer working so there is not fallback.

avatar gunjanpatel
gunjanpatel - comment - 6 Jun 2016

I am getting the same error which @AnishaVora is getting.

screen shot 2016-06-06 at 08 05 21


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 6 Jun 2016

so your SMTP fails and your fallback also fails.

To test this you have to php mail function working properly to have a fallback in case SMTP does not work.

Probably you don't have a correct sendmail path in your server.
Check if your php ini sendmail_path is correct: http://php.net/manual/en/mail.configuration.php#ini.sendmail-path

avatar AnishaVora
AnishaVora - comment - 8 Jun 2016

Hello,
I have tested this successfully with empty SMTP username and password (re-tested after installing sendmail). After applying the patch the following message is displayed.
screen shot 2016-06-08 at 05 20 00


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar AnishaVora AnishaVora - test_item - 8 Jun 2016 - Tested successfully
avatar AnishaVora
AnishaVora - comment - 8 Jun 2016

I have tested this item successfully on a90a531


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Jun 2016

nice thanks!

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Jun 2016
avatar gunjanpatel gunjanpatel - change - 8 Jun 2016
Status Pending Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 8 Jun 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2016
Labels Added: ?
avatar gunjanpatel
gunjanpatel - comment - 8 Jun 2016

I can also confirm the test successful as I was there while Anisha was testing this issue on her machine. ????


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar wilsonge
wilsonge - comment - 15 Jun 2016

Conflicts please :)

avatar wilsonge wilsonge - change - 15 Jun 2016
Milestone Added:
avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jun 2016

This PR has received new commits.

CC: @AnishaVora, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jun 2016

conflicts fixed

avatar joomla-cms-bot
joomla-cms-bot - comment - 15 Jun 2016

This PR has received new commits.

CC: @AnishaVora, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10370.

avatar andrepereiradasilva
andrepereiradasilva - comment - 15 Jun 2016

sorry for this late one, just one thing lost in the conflixcts fix
c41292d

avatar wilsonge wilsonge - change - 15 Jun 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-06-15 23:47:18
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 15 Jun 2016

It's ok :) Thanks for getting on it so fast!

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment