Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10367] - [sendtest mail] Wrap lines on json error

? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
9 May 2016

Pull Request for New Issue.

Summary of Changes

Very simple PR to wrap the lines in "Send Mail" button of global configuration when a json error occur.

Before
image

After
image

Testing Instructions

Code review, or:
1. Apply patch
2. Add in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/sendtestmail.php#L42

trigger_error('My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. My very big error message. ', E_USER_WARNING);
  1. Go to global config in the admin panel and send a test mail
  2. Check if the error text is wraped
avatar andrepereiradasilva andrepereiradasilva - open - 9 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 9 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Added: ? ?
avatar zero-24 zero-24 - test_item - 10 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on 5336cc3

Works good. Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10367.

avatar zero-24 zero-24 - change - 10 May 2016
Category ⇒ Templates (admin) UI/UX
avatar zero-24 zero-24 - change - 10 May 2016
Easy No ⇒ Yes
avatar brianteeman
brianteeman - comment - 10 May 2016

I am really not a fan of having inline css in a language string

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10367.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 May 2016

i understand, but it's already there so...

avatar brianteeman
brianteeman - comment - 10 May 2016

Ignore me then

avatar brianteeman brianteeman - test_item - 11 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 May 2016

I have tested this item :white_check_mark: successfully on 5336cc3

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10367.

avatar brianteeman brianteeman - change - 11 May 2016
Status Pending ⇒ Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 11 May 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10367.

avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 11 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 16 May 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-16 16:16:34
Closed_By ⇒ rdeutz
avatar zero-24
zero-24 - comment - 16 May 2016

@joomla-cms-bot did you miss to fix the label here? :P

avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment