[#10361] - Installation models folder review and cs
- Fixed in Code Base
- 14 Aug 2016
- Medium
- Build: staging
- Easy Test
- # 10361
- Diff
- zero-24:installmodelcs
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Code Review and CS for the models folder of the installation
Testing Instructions
Confirm that the installation still works with this branch: https://github.com/zero-24/joomla-cms/archive/installmodelcs.zip
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Easy | No | ⇒ | Yes |
| Category | Code style | ⇒ | Installation Code style |
I have tested this item
Tested install. 1. install with demo datas and 2. install multilang.
No issues.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10361.
I have tested this item
Just code review because only a language string has been changed since my last successful test + language string exists in installation/language/en-GB/en-GB.ini.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10361.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10361.
| Status | Pending | ⇒ | Ready to Commit |
RTC- looks like we have two successful tests and travis is happy - just not updated on the tracker
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10361.
| Labels |
Added:
?
|
||
Is there any reason to not get the 3.6.3 milestone here?
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 09:07:50 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
Same here it looks like this is realy hard to test? Please let me know what is unclear than I can add a better desciption ;)