Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10356] - Custom serialise JUser object without breaking B/C

? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
9 May 2016

This PR is in continuation with #8805. Thanks @wilsonge.

This is to fix the B/C break that was caused by the serialized data not matching the new class prototype for the JUser.

The serialized output has a slight change with this PR. Such as current output is C:5:"JUser":20:{a:1:{i:0;s:3:"256";}} whereas the new output would be O:5:"JUser":1:{s:2:"id";s:3:"256";} for JUser with user id 256 but I think that is not any issue, right?

I am intentionally leaving out the description and test instruction here so that you could have a look at the original PR and understand any negative/positive implications with my proposition.

See details here #8805 Serialize the user object

Additional Test Instructions

  • Start without this patch AND also without #8805 (Preferably over a public release version like 3.5.1)
  • Login to front-end and/or back-end
  • Apply this patch
  • Try to navigate to various pages in front-end and/or back-end.

Expected result: Nothing should break and you should be able to work seamlessly.

avatar izharaazmi izharaazmi - open - 9 May 2016
avatar izharaazmi izharaazmi - change - 9 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Added: ?
avatar zero-24 zero-24 - change - 9 May 2016
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 9 May 2016
Easy No ⇒ Yes
avatar izharaazmi izharaazmi - change - 9 May 2016
The description was changed
avatar izharaazmi izharaazmi - change - 9 May 2016
The description was changed
avatar izharaazmi izharaazmi - change - 9 May 2016
The description was changed
avatar ggppdk ggppdk - test_item - 10 May 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 10 May 2016

I have tested this item :white_check_mark: successfully on e00c126

Seems to work (i have not studied the code, i only tested if it works):

0 . NOTE if you updated your local repository to be after the commit 02fc45b then you can do:

git checkout 02fc45b~

1 . Log to frontend and backend
2 . Go back to staging branch and pull latest changes into local repository

git checkout staging
git fetch --all
git pull

3 . Frontend and backend break with same messages:

Warning: Erroneous data format for unserializing 'JUser' in D:\xampp_php70\htdocs\devel\joomla-cms2\libraries\joomla\session\session.php on line 646
Notice: unserialize(): Error at offset 861 of 960 bytes in D:\xampp_php70\htdocs\devel\joomla-cms2\libraries\joomla\session\session.php on line 646
Fatal error: Call to a member function get() on boolean in D:\xampp_php70\htdocs\devel\joomla-cms2\libraries\joomla\session\session.php on line 503
Fatal error: __clone method called on non-object in D:\xampp_php70\htdocs\devel\joomla-cms2\libraries\joomla\session\session.php on line 380

4 . Get pull request into a new branch and check it out (because you cannot apply patch via patch tester anymore because backend is broken AND if you close browser window then you can no longer test this fix):

git fetch origin pull/10356/head:juser_serialize_fix
git checkout juser_serialize_fix

5 . Frontend and Backend work again

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10356.

avatar izharaazmi
izharaazmi - comment - 11 May 2016

@ggppdk Well explained. Thank you! ????

avatar wilsonge wilsonge - close - 11 May 2016
avatar wilsonge wilsonge - merge - 11 May 2016
avatar wilsonge wilsonge - close - 11 May 2016
avatar wilsonge wilsonge - reference | d9234b7 - 11 May 16
avatar wilsonge wilsonge - merge - 11 May 2016
avatar wilsonge wilsonge - close - 11 May 2016
avatar wilsonge wilsonge - change - 11 May 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-11 07:19:22
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - change - 11 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 11 May 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 11 May 2016

Thank you very much for looking into this! It's really appreciated :)

avatar izharaazmi
izharaazmi - comment - 11 May 2016

You're welcome. Joomla! ❤️ ????

Add a Comment

Login with GitHub to post a comment