Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#10353] - Important! Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks

? Pending
Pull Request for # 10352

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
9 May 2016

Pull Request for Issue #10352.

Summary of Changes

Change new pkg_en-GB id to 802 since some sites can be using 801 for pkg_weblinks.
Also changed the sql to not use the update_site_id.

Testing Instructions

Two tests needed:

New Install
Upgrade

Note: This update package changes version to 3.6.1-dev and adds a weblinks id 801 and after do the changes in this PR (you can check that by unzipping this small package).

Tests
  1. After install go to Extensions -> Manage -> Install Languages (Find Languages button) and check the languages are there
  2. Go to Extensions -> Manage -> Update Sites and check there is a English language package update site
  3. Go to Extensions -> Manage -> Manage and check there is a "Package" extension called "English language package"

Observation

Please confirm 802 has never been used by other package in joomla history.

avatar andrepereiradasilva andrepereiradasilva - open - 9 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 9 May 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 9 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 9 May 2016
The description was changed
avatar zero-24 zero-24 - change - 9 May 2016
Category ⇒ Updating
avatar zero-24 zero-24 - change - 9 May 2016
Rel_Number 0 ⇒ 10352
Relation Type ⇒ Pull Request for
avatar infograf768 infograf768 - test_item - 9 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 9 May 2016

I have tested this item :white_check_mark: successfully on 4393c07

Works, if nothing is set to id 802

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10353.

avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Title
…
Important! Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Title
…
Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
Important! Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
avatar infograf768 infograf768 - change - 9 May 2016
Title
…
Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
Important! Change pkg_en-GB id to 802, since 801 can be used by pkg_weblinks
avatar infograf768
infograf768 - comment - 10 May 2016

@zero-24 @roland-d @wilsonge
This is an important patch to get in 3.6.0 as updating can be broken easily.

avatar roland-d roland-d - change - 10 May 2016
Labels Added: ?
avatar brianteeman brianteeman - close - 11 May 2016
avatar wilsonge wilsonge - close - 11 May 2016
avatar wilsonge wilsonge - merge - 11 May 2016
avatar wilsonge wilsonge - reference | b282859 - 11 May 16
avatar wilsonge wilsonge - merge - 11 May 2016
avatar wilsonge wilsonge - close - 11 May 2016
avatar wilsonge wilsonge - change - 11 May 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-05-11 21:10:25
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - change - 11 May 2016
Milestone Added:
avatar brianteeman brianteeman - change - 12 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment