? ? Success

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
9 May 2016

Summary of Changes

  • New JForm Class method getFieldXml as public getter for the protected method findField
  • New parameter path for the setField method of JForm, allows to add a field at a specific place in the xml tree.

Can be merged on review

avatar rdeutz rdeutz - open - 9 May 2016
avatar rdeutz rdeutz - change - 9 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 9 May 2016
Labels
avatar brianteeman brianteeman - change - 9 May 2016
Category Libraries Unit Tests
avatar zero-24 zero-24 - change - 9 May 2016
Category Libraries Unit Tests Unit Tests
avatar zero-24 zero-24 - change - 9 May 2016
Category Unit Tests Libraries Unit Tests
avatar infograf768
infograf768 - comment - 29 May 2016

Looks like Travis did not find the tab instead of space for each
@param string $path Tree elements a doc separated list where we add the node.
after $path

avatar rdeutz
rdeutz - comment - 29 May 2016

@infograf768 don't understand your comment

avatar wilsonge
wilsonge - comment - 30 May 2016

Robert what's the use case for making this method public?

avatar rdeutz
rdeutz - comment - 31 May 2016

To add a field you need a simplexml object, so if you like to change the ordering of fields within a fiedset you have to get the field information, remove fields, create simplexml objects and add them with getting the simpleXml object directly you can skip the "create simplexml opbjects" part

avatar infograf768
infograf768 - comment - 11 Jun 2016

@rdeutz
I meant on these lines:

     * @param   string            $path    Tree elements a dot separated list where we add the node.

There is a tab and 3 or 4 spaces after $path instead of 4 or 5 spaces
here for example (grey triangle is a Tab):

screen shot 2016-06-11 at 12 04 24
spaces.

avatar brianteeman
brianteeman - comment - 3 Aug 2016

@rdeutz can you look at the comment from @infograf768 please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10350.

avatar rdeutz
rdeutz - comment - 3 Aug 2016

@brianteeman I fixed it but I think I need to write more instruction because this is a quite complicated thing to understand, is on my list

avatar brianteeman
brianteeman - comment - 3 Aug 2016

Thanks @rdeutz

avatar roland-d
roland-d - comment - 3 Nov 2016

@rdeutz Did you find some time to write test instructions?

avatar rdeutz
rdeutz - comment - 3 Nov 2016

@roland-d yes and while writing it I found that I have to change something

avatar roland-d
roland-d - comment - 3 Nov 2016

@rdeutz So we should not test this yet I guess?

avatar rdeutz
rdeutz - comment - 3 Nov 2016

@roland-d your guess is right, PBF somewhere?

avatar roland-d
roland-d - comment - 3 Nov 2016

@rdeutz Not yet, tomorrow we have a PBF in NL

avatar euismod2336
euismod2336 - comment - 4 Nov 2016

well, will not test this then :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10350.

avatar rdeutz rdeutz - change - 26 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-26 11:26:21
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Mar 2017

Add a Comment

Login with GitHub to post a comment