? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
8 May 2016

Summary of Changes

A check is added to JCacheStorage::getInstance() to ensure the cache store that is about to be instantiated is supported on the platform and will throw a RuntimeException if not. This should help prevent trying to use a storage class that isn't compatible with the platform and instead of possibly hitting PHP Fatal errors the app will more gracefully die with the Exception being thrown.

Testing Instructions

Set your configuration's cache_handler value to use a cache store that isn't supported on your platform. Pre-patch it will most likely lead to a fatal error or some other kind of Exception/Throwable depending on your setup; post-patch you should get an error page telling you the cache store isn't supported.

avatar mbabker mbabker - open - 8 May 2016
avatar mbabker mbabker - change - 8 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on b9ab3ba

Changed to "memcache" in configuration.php file (which i don't have).
Also tried a different one "cachey" that doesn't exist

After patch got this errors
An error has occurred.
0 The memcache Cache Storage is not supported on this platform.

An error has occurred.
0 Unable to load Cache Storage: cachey


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10339.

avatar brianteeman brianteeman - change - 8 May 2016
Category Cache
avatar alikon alikon - test_item - 29 May 2016 - Tested successfully
avatar alikon
alikon - comment - 29 May 2016

I have tested this item successfully on b9ab3ba


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10339.

avatar brianteeman brianteeman - change - 29 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 29 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10339.

avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 29 May 2016
Milestone Added:
avatar roland-d roland-d - change - 31 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-31 07:51:58
Closed_By roland-d
avatar roland-d roland-d - close - 31 May 2016
avatar roland-d roland-d - merge - 31 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 31 May 2016
avatar roland-d roland-d - reference | c424033 - 31 May 16
avatar roland-d roland-d - merge - 31 May 2016
avatar roland-d roland-d - close - 31 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2016
Labels Removed: ?
avatar roland-d
roland-d - comment - 31 May 2016

Thanks everybody

Add a Comment

Login with GitHub to post a comment