[#10322] - Add id on installer buttons
- Fixed in Code Base
- 8 May 2016
- Medium
- Build: staging
- # 10322
- Diff
- 810:install
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
we need an id on the buttons for better codestyle, on unittests
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
as mbabker comments
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
I have tested this item 
unsuccessfully on 388ff2f
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
Thank you for your contribution but it has been decided that this is not something that will be included in the core of Joomla.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 15:30:14 |
| Closed_By | ⇒ | brianteeman |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-05-08 15:30:14 | ⇒ | |
| Closed_By | brianteeman | ⇒ |
| Status | New | ⇒ | Closed |
| Status | Closed | ⇒ | Pending |
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
I have tested this item 
successfully on 5c2c8f4
on review.
ids are now different.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
I have tested this item successfully on 5c2c8f4
The IDs are unique and are set correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
I have tested this item successfully on 5c2c8f4
ids are now different and unique. Thanks :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Labels |
Removed:
?
|
||
Setting to RTC, we have 2 successful tests
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 15:56:36 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Sorry for the confusion - posted on a wrong issue
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.
Aren't these all displayed on the same page? If so they can't use the same ID.