? Pending

User tests: Successful: Unsuccessful:

avatar 810
810
8 May 2016

we need an id on the buttons for better codestyle, on unittests

avatar 810 810 - open - 8 May 2016
avatar 810 810 - change - 8 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar mbabker
mbabker - comment - 8 May 2016

Aren't these all displayed on the same page? If so they can't use the same ID.

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

as mbabker comments


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar andrepereiradasilva andrepereiradasilva - alter_testresult - 8 May 2016 - andrepereiradasilva: Tested unsuccessfully
avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :red_circle: unsuccessfully on 388ff2f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar brianteeman
brianteeman - comment - 8 May 2016

Thank you for your contribution but it has been decided that this is not something that will be included in the core of Joomla.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar brianteeman brianteeman - close - 8 May 2016
avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-08 15:30:14
Closed_By brianteeman
avatar brianteeman brianteeman - close - 8 May 2016
avatar roland-d roland-d - reopen - 8 May 2016
avatar roland-d roland-d - change - 8 May 2016
Status Closed New
Closed_Date 2016-05-08 15:30:14
Closed_By brianteeman
avatar roland-d roland-d - change - 8 May 2016
Status New Closed
avatar roland-d roland-d - change - 8 May 2016
Status Closed Pending
avatar roland-d roland-d - reopen - 8 May 2016
avatar joomla-cms-bot
joomla-cms-bot - comment - 8 May 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar joomla-cms-bot
joomla-cms-bot - comment - 8 May 2016

This PR has received new commits.

CC: @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 5c2c8f4

on review.
ids are now different.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar roland-d roland-d - test_item - 8 May 2016 - Tested successfully
avatar roland-d
roland-d - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 5c2c8f4

The IDs are unique and are set correctly.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar yvesh yvesh - test_item - 8 May 2016 - Tested successfully
avatar yvesh
yvesh - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 5c2c8f4

ids are now different and unique. Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar zero-24 zero-24 - change - 8 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 8 May 2016

RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar roland-d roland-d - change - 8 May 2016
Milestone Added:
avatar roland-d roland-d - change - 8 May 2016
Milestone Added:
Labels Removed: ?
avatar roland-d
roland-d - comment - 8 May 2016

Setting to RTC, we have 2 successful tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar zero-24
zero-24 - comment - 8 May 2016

we have 3 @roland-d and 2 who try to add the RTC label :smile:

avatar Kubik-Rubik
Kubik-Rubik - comment - 8 May 2016

Thank you @810 and testers!

avatar Kubik-Rubik Kubik-Rubik - reference | e5969d4 - 8 May 16
avatar Kubik-Rubik Kubik-Rubik - merge - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-08 15:56:36
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - merge - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 8 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 8 May 2016

Sorry for the confusion - posted on a wrong issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10322.

Add a Comment

Login with GitHub to post a comment