[#10317] - [minor fixes] modal module edition
- Fixed in Code Base
- 9 May 2016
- Medium
- Build: staging
- # 10317
- Diff
- JoomliC:_Fix]-modal-module-edition
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
A few minor fixes for modal module edit (in menu item edition)
Summary of Changes
- Fix Close button not handling module edit close button (after close of the modal, the module was locked)
- Fix Tooltip placement (truncated at top)
- Add Container for iframe content
- Allow close only if click on Close or Save&Close buttons (to prevent accidental close while editing)
Testing Instructions
Before apply the patch:
- Go to menus, and open one menu item
- Click on one of the module in "Module Assignment" tab, to open the module edition
- Then check Tooltip for title (truncated)
- Then click with changing nothing, on the bottom CLOSE button of the modal
- Go to Modules Manager : the module is locked
Example of "close" button issue with module named here "Archived Articles"
Apply patch, and :
- verify tooltip placement
- test as above, and check that now the module is not locked (the module edition was well closed)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Category | ⇒ | Modules |
This PR has received new commits.
CC: @BurtNL
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10317.
Thanks for testing @BurtNL but test reset as i've just updated this PR with the same fix for this issue : #10292 (comment) ;-)
I have tested this item 
successfully on 8f48352
Tested again with this updated patch.
Followed the test instructions and works exactly as described, nice tooltip on the title and no lock on module after applying this patch.
And the modal can now only be closed via the buttons. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10317.
I have tested this item successfully on 8f48352
Works as described - Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10317.
I have tested this item successfully on 8f48352
Solves the issues and works as described. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10317.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-09 20:12:27 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 4d6a9f5
Followed the test instructions and works exactly as described, nice tooltip on the title and no lock on module after applying this patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10317.