? Success

User tests: Successful: Unsuccessful:

avatar Kubik-Rubik
Kubik-Rubik
8 May 2016

Pull Request for Issue #7963.

Summary of Changes

Removed small error in the mentioned PR.

Testing Instructions

Please merge by code review. All kudos to @Mathewlenning!

avatar Kubik-Rubik Kubik-Rubik - open - 8 May 2016
avatar Kubik-Rubik Kubik-Rubik - change - 8 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 8 May 2016
Category Code style
avatar brianteeman brianteeman - change - 8 May 2016
Milestone Added:
avatar brianteeman
brianteeman - comment - 8 May 2016

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10305.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2016
Milestone Removed:
avatar zero-24 zero-24 - change - 16 May 2016
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 16 May 2016

Get off RTC for now.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10305.

avatar brianteeman brianteeman - change - 21 Jul 2016
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 3 Aug 2016

Is someone able to do a code review of this please @mbabker @roland-d @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10305.

avatar roland-d
roland-d - comment - 3 Aug 2016

@brianteeman Robert and I did check before and requested @Kubik-Rubik to update the PR. I have checked the rest of the PR as well and posted my comments.

avatar laoneo
laoneo - comment - 8 Dec 2016

Can you please update the branch and solve the conflicts that we can do another round of testing?

avatar Kubik-Rubik Kubik-Rubik - change - 3 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-03 10:00:10
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 3 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2017
Category Code style Libraries Code style

Add a Comment

Login with GitHub to post a comment