Joomla! Issue Tracker | Joomla! CMS #10303 - Smart Search: utf8

Fixed in Code Base
8 May 2016
Medium
Build: staging
# 10303
Diff
chrisdavenport:patch-3

Pending

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

chrisdavenport
8 May 2016

Under some circumstances a search for a word can result in a "PHP Fatal error: utf8_strpos: Offset must be an integer". This is because the floor function used to calculate the offset can sometimes return a float rather than an int.

Summary of Changes

The return value from the floor is now cast to an int to make sure that the offset (the 3rd argument) passed to JString::strpos, which becomes the offset argument to utf8_strpos, is always an int.

Testing Instructions

This may be tricky to replicate but this is how I encountered the problem in the first place...

Fresh install of Joomla with the Testing sample data set (the last option on the list).
Enable Smart Search and index the content.
From the front-end, go to the Smart Search search component page.
Enter "the" as the search term and click Search.

This should throw the error on one of the search results. For me it happened on "Modules" and "Sample Sites".

Apply this PR and repeat the test.

4fb9192 8 May 2016

Smart Search: utf8_strpos: Offset must be an integer

chrisdavenport - open - 8 May 2016

chrisdavenport - change - 8 May 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 8 May 2016

Labels

Added: ?

brianteeman - change - 8 May 2016

Category

⇒

chrisdavenport - comment - 8 May 2016

One more thing: This might be PHP7-related. I don't have access to an earlier PHP release at the moment to test it, but it's strange that I haven't seen this issue until running on PHP7 for the first time.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10303.}