[#10294] - [com_menus] menus view: solve menus view link inconsistency
- Closed
- 6 Sep 2016
- Medium
- Build: staging
- # 10294
- Diff
- andrepereiradasilva:patch-6
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
When we are in Menus -> Manage (com_menus, menus view) we have two links like this
But, the link behaviour is different from all other views. In all other views the title/name is the link to edit the item.
So this PR exchange the links for better UX and consistency. Also adds a "Edit" tooltip.
Testing Instructions
- Apply patch in latest staging
- Go to Menus -> Manage and check the links.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
since we now have counting i propose to remove the link to the menu items.
This would be consistent with, for instance, the category alias.
| Category | ⇒ | Administration |
I have thought about this behaviour for a long time recently as I always click on the wrong one myself. I understand why it is the way that it is but I agree that this is not consistent and should be fixed (swapped)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10294.
ok. So test please.
I have tested this item 
successfully on a981021
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10294.
I have tested this item successfully on a981021
I've tested this PR successfully. It does what it says.
However, the "manage menu items" links are used a lot more than the "edit menu settings" links.
IMHO changing them like this PR is not an improvement.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10294.
I have tested this item successfully on a981021
to confirm it works but I already commented I'm very skeptical
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10294.
how about adding a column with link to the menu items and removing the link from the "menu type"?
i can do that if it helps the skeptics :)
| Status | Pending | ⇒ | Needs Review |
Thanks for the code and the tests. I am setting this to Needs Review so that the CMS maintainers can make a decision about this changed behaviour
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10294.
clicked again on the menu name to edit the menu and was redirected to that menu menu items ... as said, i think this is not good UX
Need review ...
Why not have 2 columns, one for each?
well, i don't care, if is one or two columns.
IMO this is a usability error.
In all other views when you click the item title you go to the edit page of that item, but not on this one.
This PR is to solve that usability error.
can a mantainer please take a decision here? merge or close?
I am in the same boat, I also click often on the wrong link. I don't think this here is a good solution, for making a UI change we should come up we something more brilliant. :-) We then this is something for a minor release so I am closing this and we might can ping our UI/UX group to think about it and come up with something.
Thank you all for the discussion and thanks @andrepereiradasilva for working on this.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-06 15:40:04 |
| Closed_By | ⇒ | rdeutz |
| Category | Administration | ⇒ | Administration Components |
sorry to read this decision, but it's your call.
#10294 works as described but even if IMHO there IS an inconsistency having to click on
(what doesn't mean I have a better solution)
Menu Typeto edit the menu, I'm not sure the solution here is more consistent