? Success

User tests: Successful: Unsuccessful:

avatar JoomliC
JoomliC
7 May 2016

To reproduce issue before applying this patch, create a new menu item, select type "single article", and save this menu item.
Then, click "Edit" button to edit the article from the menu item.

Current behavior (before patch) :

  • Open the article edition page (modal) in a new browser window or tab (!!!), and NOT inside a Bootstrap modal :-|

capture d ecran 2016-05-07 a 22 43 12
capture d ecran 2016-05-07 a 22 43 26

Expected behavior :

  • Open the article edition page inside a modal, with close and save & close buttons
  • Same behavior as current one for Edition of modules from the menu item (in Module Assignment tab) when clicking on the name of each modules.

capture d ecran 2016-05-07 a 22 45 08

Summary of Changes

  • Open the Article Edition modal inside a bootstrap modal
  • Simplify the modal.php view (loading directly the edit.php view)
  • Change in edit.php to not load Articles Association tab when inside a modal (previous behavior and expected one).
  • Fix tooltip placement inside modal-body loading an iframe

Testing Instructions

  • Test in Menus > Menu Item type "single article" > Edit article to open the modal to edit article
  • Test in Articles > Article Edition > Associations > Select an associated article, save and then try to edit this article associated with Edit button (should open the modal).

If it's ok for this one (modal edit article) i will do the same for all menu item type "single item" : Newsfeed modal (menu item type single newsfeed), Contact modal (type single contact), etc...

avatar JoomliC JoomliC - open - 7 May 2016
avatar JoomliC JoomliC - change - 7 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 May 2016

Before testing, i wonder if i should remove the existed "clear" button from the article.php form field, as this one is not used, and not needed because when creating a menu item type single article, this input could not be empty (so clear button makes no sense, and in fact the code for this button is not needed and not used...)

Don't know which button you're talking.

it's a pitty #10070 is not merged yet. Would be perfect to have a full size modal for this "Edit".

Test in Menus > Menu Item type "single article" > Edit article to open the modal to edit article
Ok

Test in Articles > Article Edition > Associations > Select an associated article, save and then try to edit this article associated with Edit button (should open the modal).

Js error when creating/editing article.

Used latest staging

avatar andrepereiradasilva
andrepereiradasilva - comment - 7 May 2016

The aim of this PR is great.

If you are in the mood after this changes, it would be great to have a "New" article button in the single article menu item :)

avatar JoomliC JoomliC - change - 7 May 2016
The description was changed
avatar JoomliC
JoomliC - comment - 8 May 2016

@andrepereiradasilva

Don't know which button you're talking.

Don't worry, just edited the PR description... A stupid comment, as "clear" button is needed in Article associated edition, and so, all is good about this!

I have update the PR, due to a few possible issue with Association Article.
Did many tests, and seems working good.

If you are in the mood after this changes, it would be great to have a "New" article button in the single article menu item :)

Yes, exactly what i thought when working to fix modal item edit in menu edition: a new button.
The first step, with this PR, and with a few others if this one is ok, is to fix what exists first (but the possibility to directly create an article from the menu and/or when adding an associated article could be nice... not yet tested if could work well).

So i will say that now this PR is ready for testing !

avatar brianteeman brianteeman - change - 8 May 2016
Category Components
avatar BurtNL BurtNL - test_item - 8 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 99115df

Tested successfully, works as described. Nice feature.

One remark: if you accidentally click outside of the modal window, while editing an article, the modal closes directly and all your changes are gone.
Users have to be aware of that.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 99115df

This works as described.

I make the same comment as @BurtNL and also. It should exist a "Save" button.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

oh and by the way, when "Save & Close" a meesage saying that it was been saved would be used full to.

avatar JoomliC
JoomliC - comment - 8 May 2016

Thank you for testing @andrepereiradasilva and @BurtNL !
The aim of this PR is mainly to fix the edit modal not openning in a modal, and fix and simplify existing code.
Of course, your comments are welcome! I agree with you that a few improvements could be done for this feature ;-)

It should exist a "Save" button

I did this one as it is for module edition (in menu edit, go to "Module Assignment" tab, and click on one module name : this one opens in a modal, and did the same here with article).
So future improvements will be of course possible ;-)

avatar joomla-cms-bot
joomla-cms-bot - comment - 8 May 2016

This PR has received new commits.

CC: @andrepereiradasilva, @BurtNL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar JoomliC
JoomliC - comment - 8 May 2016

@andrepereiradasilva and @BurtNL Sorry, tests are reset ;-)

I have added 2 options ot BS modal, to disable close by accident. Fix this :

One remark: if you accidentally click outside of the modal window, while editing an article, the modal closes directly and all your changes are gone.
Users have to be aware of that.

;-)

avatar andrepereiradasilva andrepereiradasilva - test_item - 8 May 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 3f1cea6

test just the modal part and now it doesn't close unless we save & close or close


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar BurtNL BurtNL - test_item - 8 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 8 May 2016

I have tested this item :white_check_mark: successfully on 3f1cea6

Tested successfully, modal can now only be closed via the buttons. Great!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 8 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10292.

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

3.6 label?

avatar brianteeman brianteeman - change - 8 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 9 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-09 20:19:18
Closed_By rdeutz
avatar rdeutz rdeutz - close - 9 May 2016
avatar rdeutz rdeutz - merge - 9 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 9 May 2016
avatar rdeutz rdeutz - reference | c4dea32 - 9 May 16
avatar rdeutz rdeutz - merge - 9 May 2016
avatar rdeutz rdeutz - close - 9 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment