User tests: Successful: Unsuccessful:
To reproduce issue before applying this patch, create a new menu item, select type "single article", and save this menu item.
Then, click "Edit" button to edit the article from the menu item.
Current behavior (before patch) :
Expected behavior :
close
and save & close
buttonsIf it's ok for this one (modal edit article) i will do the same for all menu item type "single item" : Newsfeed modal (menu item type single newsfeed), Contact modal (type single contact), etc...
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
The aim of this PR is great.
If you are in the mood after this changes, it would be great to have a "New" article button in the single article menu item :)
Don't know which button you're talking.
Don't worry, just edited the PR description... A stupid comment, as "clear" button is needed in Article associated edition, and so, all is good about this!
I have update the PR, due to a few possible issue with Association Article.
Did many tests, and seems working good.
If you are in the mood after this changes, it would be great to have a "New" article button in the single article menu item :)
Yes, exactly what i thought when working to fix modal item edit in menu edition: a new button.
The first step, with this PR, and with a few others if this one is ok, is to fix what exists first (but the possibility to directly create an article from the menu and/or when adding an associated article could be nice... not yet tested if could work well).
So i will say that now this PR is ready for testing !
Category | ⇒ | Components |
I have tested this item successfully on 99115df
Tested successfully, works as described. Nice feature.
One remark: if you accidentally click outside of the modal window, while editing an article, the modal closes directly and all your changes are gone.
Users have to be aware of that.
I have tested this item successfully on 99115df
This works as described.
I make the same comment as @BurtNL and also. It should exist a "Save" button.
oh and by the way, when "Save & Close" a meesage saying that it was been saved would be used full to.
Thank you for testing @andrepereiradasilva and @BurtNL !
The aim of this PR is mainly to fix the edit modal not openning in a modal, and fix and simplify existing code.
Of course, your comments are welcome! I agree with you that a few improvements could be done for this feature ;-)
It should exist a "Save" button
I did this one as it is for module edition (in menu edit, go to "Module Assignment" tab, and click on one module name : this one opens in a modal, and did the same here with article).
So future improvements will be of course possible ;-)
This PR has received new commits.
CC: @andrepereiradasilva, @BurtNL
@andrepereiradasilva and @BurtNL Sorry, tests are reset ;-)
I have added 2 options ot BS modal, to disable close by accident. Fix this :
One remark: if you accidentally click outside of the modal window, while editing an article, the modal closes directly and all your changes are gone.
Users have to be aware of that.
;-)
I have tested this item successfully on 3f1cea6
test just the modal part and now it doesn't close unless we save & close or close
I have tested this item successfully on 3f1cea6
Tested successfully, modal can now only be closed via the buttons. Great!
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
3.6 label?
Milestone |
Added: |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-09 20:19:18 |
Closed_By | ⇒ | rdeutz |
Labels |
Removed:
?
|
Don't know which button you're talking.
it's a pitty #10070 is not merged yet. Would be perfect to have a full size modal for this "Edit".
Js error when creating/editing article.
Used latest staging