[#10286] - Make default CODEMIRROR parameter values in PHP equal to the default parameter values in XML
- Fixed in Code Base
- 6 Jun 2017
- Medium
- Build: staging
- # 10286
- Diff
- n9iels:codemirror-parameters
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
This PR is a replaces #7653
The problem
The default values of the codemirror parameters defined in the PHP file are not equal to the default values of the parameters defined in the XML file. The result of this is that on a new installation the active line is highlighted but the XML parameter is set to "no".
Changes
- Set the default values in the XML file equal to the PHP file
- Apply the Joomla! Codestyle for XML files
How to test
Just confirm that the all the parameters are working correct. The only thing that is changed are the default values of the XML parameters.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
The only changes I made are the default values in the XML file. These values are only applied when the parameters are not in the database or if they are empty.
So on a site update the current configuration of the parameters will be untouched.
Which means that it doesn't fix existing sites ?
Historically updates haven't touched sites' existing configs unless
absolutely necessary.
On Saturday, May 7, 2016, Brian Teeman notifications@github.com wrote:
Which means that it doesn't fix existing sites ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10286 (comment)
That determines on what you call "wrong" parameters. Keep in mind there are no problems with the current parameters. The only thing is that when you save the parameters of codemirror for the first time the configuration change after save.
Example:
in the PHP file the following parameter is configured $this->params->get('activeLine', true) but the XML says this:
<field
name="activeLine"
type="radio"
class="btn-group btn-group-yesno"
default="0"
filter="options"
description="PLG_CODEMIRROR_FIELD_ACTIVELINE_DESC"
label="PLG_CODEMIRROR_FIELD_ACTIVELINE_LABEL"
>
<option value="1">JON</option>
<option value="0">JOFF</option>
</field>If the parameters are not in the database the active line will be highlighted, because this is the default value. When open the plugin settings of code mirror, the setting for the active line is default set to 0. So when save the settings the active line won't be highlighted any more.
If this patch is applied there are is no difference any more with the default PHP values and default XML values. So when save the parameters for the first time nothing changed.
If the user already save the parameters also nothing will happen and the current situation will be untouched.
| Rel_Number | 0 | ⇒ | 7363 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Code style |
| Category | Code style | ⇒ | Code style Plugins |
| Title |
|
||||||
Updated title to show it is for codemirror
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10286.
| Title |
|
||||||
| Category | Code style Plugins | ⇒ | Plugins Front End Code style |
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10286.
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10286.
| Status | Pending | ⇒ | Information Required |
@franz-wohlkoenig update date now
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10286.
| Status | Information Required | ⇒ | Discussion |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10286.
| Status | Discussion | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-06 18:24:45 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
What happens on a site update. Are the "wrong" params still in the database?