? Failure

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
7 May 2016

Pull Request for Issue #10191. This PR adds a link to the front-end view of a single article in the Article: Edit view. It only works for saved articles (that have an ID) and the links are non-SEF links.

Note as it's a proof-of-concept PR, I did not add a Language String but used the hardcoded label "link to article".

@sanek4life Is this the functionality that you were asking for in issue #10191?
Could you please test it?

Testing Instructions

Before the PR

Go to Content > Articles > open an article
article-edit-before

Before the PR

Go to Content > Articles > open an article, on the bottom right you'll have a non-SEF link to the front-end view of an article.
article-edit-after

avatar pe7er pe7er - open - 7 May 2016
avatar pe7er pe7er - change - 7 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Category Administration Components
avatar sanek4life
sanek4life - comment - 12 May 2016

@pe7er i test it! it works right!

test right

avatar pe7er
pe7er - comment - 12 May 2016

@sanek4life Is this the functionality you were looking for?

btw: I've added the link with a core hack. If this feature is not further developed and added to the Joomla core, then this functionality could be added with a plugin that will add the link to the Article Edit form...

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 May 2016

JRoute::_(xxxxx) doesn't support making URL from admin to site and vice versa.

I tried to change it a while ago to support that, but run into some issues with SEF and the language plugin. See andrepereiradasilva#36

If you want to contribute to try to solve this problems it would be great.

avatar sanek4life
sanek4life - comment - 12 May 2016

@pe7er yes!

avatar crommie crommie - test_item - 25 Jun 2016 - Tested successfully
avatar crommie
crommie - comment - 25 Jun 2016

I have tested this item successfully on 2545cf2

Link shown as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10282.

avatar zero-24
zero-24 - comment - 25 Jun 2016

@pe7er can you have a look here? Travis is failing and this looks not really ready to merge? e.g. we don't use a language string?! I'm confused

avatar pe7er
pe7er - comment - 25 Jun 2016

@zero-24 Sure, I'll create a new patch for this to correct it, and to improve it....

avatar infograf768
infograf768 - comment - 25 Jun 2016

Looked at this. It lacks the language when language is not set to All and we are in multilang.
The link you should get imho should be similar to the one we get when using the Article button in TinyMCE.
I.e.
<a href="index.php?option=com_content&amp;view=article&amp;id=213&amp;catid=10&amp;lang=en-GB&amp;Itemid=101" hreflang="en">some article title</a>

avatar roland-d roland-d - change - 25 Jun 2016
Status Pending Information Required
avatar roland-d
roland-d - comment - 25 Jun 2016

Setting this to Information Required as @pe7er needs to improve this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10282.

avatar pe7er
pe7er - comment - 26 Jun 2016

I've created a new PR for this: #10932

@sanek4life and @crommie Could you please test the new PR?

avatar zero-24 zero-24 - change - 26 Jun 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-06-26 12:31:48
Closed_By zero-24
avatar zero-24
zero-24 - comment - 26 Jun 2016

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/10282

avatar joomla-cms-bot joomla-cms-bot - close - 26 Jun 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 Jun 2016
avatar zero-24
zero-24 - comment - 26 Jun 2016

Closing as we have a new PR. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10282.

avatar brianteeman
brianteeman - comment - 26 Jun 2016

Closed please see #10932

Add a Comment

Login with GitHub to post a comment