[#10271] - removed unnecessary description fields in filter xml
- Closed
- 8 May 2016
- Medium
- Build: staging
- # 10271
- Diff
- pe7er:codestyle-filterxml-remove-unnecessary-desc
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8336. I've redone this with the current Joomla! 3.6.0-dev code base.
Summary of Changes
I've removed all the description fields from the filter_.xml files used by the Search Tools filters.
This time I've kept all the label fields for future use regarding accessibility (for use with "titles").
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Administration Fields |
the description fields are the tooltips and should not be removed.
For now the tooltips are just implemented in the search field, but IMHO they should be implements in all filters.
So, IMO, 
for this PR
For the reasons mentioned above I'm going to close this for now. I don't think there's any harm in allowing people to override these layouts with their own code (and from an accessibility point of view we might want to start doing so in places)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-08 14:16:58 |
| Closed_By | ⇒ | wilsonge |
Ok
You are supposing here that everybody here uses the core UI (default searchtools layouts). Data != Template & Isis != unique template.
Removing descriptions causes that nobody can show that information in their templates/layout overrides.