? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
5 May 2016

Summary of Changes

This changes a forgotten filter.client_id to client_id(the view selector).

Testing Instructions

Code review.

Observations

That i know of, this is not used in the core, but the way it is, this would not work properly if the selected client is "Administrator", because the filter.client_id state, since it doesn't exist, would always be 0.

Pinging @infograf768

avatar andrepereiradasilva andrepereiradasilva - open - 5 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - change - 5 May 2016
The description was changed
avatar infograf768 infograf768 - test_item - 5 May 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 5 May 2016

I have tested this item :white_check_mark: successfully on 732f444

makes sense. ok on review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10254.

avatar brianteeman brianteeman - change - 5 May 2016
Category Components
avatar zero-24 zero-24 - test_item - 7 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on 732f444

Thanks makes sense.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10254.

avatar zero-24 zero-24 - change - 7 May 2016
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 7 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10254.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 7 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 14:08:00
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 May 2016
avatar wilsonge wilsonge - merge - 7 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 7 May 2016
avatar wilsonge wilsonge - reference | 2b4990e - 7 May 16
avatar wilsonge wilsonge - merge - 7 May 2016
avatar wilsonge wilsonge - close - 7 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 May 2016

thanks all for testing and comments!

avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 7 May 2016

Add a Comment

Login with GitHub to post a comment