? ? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
4 May 2016

Pull Request for Improvement.

Summary of Changes

This PR adds a "Delete All" method and toolbar button to com_cache.

image

This delete all current cache for the client selected.

Testing Instructions

  1. Apply patch
  2. Go to System -> Clear Cache
  3. If you don't have any cache, activate cache in global config and navegate a little in the frontend.
  4. Test the new "Delete All" button.
avatar andrepereiradasilva andrepereiradasilva - open - 4 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 4 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 4 May 2016
The description was changed
avatar brianteeman brianteeman - change - 5 May 2016
Category Components UI/UX
avatar brianteeman brianteeman - change - 5 May 2016
Labels
avatar brianteeman brianteeman - test_item - 5 May 2016 - Not tested
avatar brianteeman
brianteeman - comment - 5 May 2016

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar BurtNL
BurtNL - comment - 5 May 2016

I have tested this issue and it works, but it only deletes the cache-items as shown on the active page.
If you have multiple pages the cache-items on the other pages are still there.
Is this how it is supposed to work?
Or do you want to delete all cache-items over all pages (even if not currenty visible) at once? (which would be great, i guess).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 May 2016

If you have multiple pages the cache-items on the other pages are still there.

What do you mean by "multiple pages"?

that i know of, in admin Clear Cache page we only have two subviews (Site or Administrator).
This Button deletes all cache groups in the selected subview.

avatar brianteeman
brianteeman - comment - 5 May 2016

Cache has a list limit just like all manager views

On 5 May 2016 at 11:49, andrepereiradasilva notifications@github.com
wrote:

If you have multiple pages the cache-items on the other pages are still
there.

What do you mean by "multiple pages"?

that i know of, in admin Clear Cache page we only have two subviews (Site
or Administrator).
This Button deletes all cache groups in the selected subview.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10246 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 May 2016

oh! i see! of course. need coffeee...

Will check that.

thanks @BurtNL @brianteeman for the comments.

avatar joomla-cms-bot
joomla-cms-bot - comment - 5 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 May 2016

ok should work now

avatar BurtNL BurtNL - test_item - 5 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 5 May 2016

I have tested this item :white_check_mark: successfully on 66e23b5

Great! Now it deletes all cache-items over multiple list views/pages.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar brianteeman brianteeman - test_item - 7 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on 66e23b5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar brianteeman brianteeman - change - 7 May 2016
Status Pending Ready to Commit
Labels
avatar brianteeman brianteeman - change - 7 May 2016
Milestone Added:
avatar zero-24 zero-24 - test_item - 7 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on 66e23b5

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10246.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Category Components UI/UX Components Feature Request UI/UX
avatar brianteeman brianteeman - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Labels
avatar wilsonge wilsonge - reference | c4e505c - 7 May 16
avatar wilsonge wilsonge - merge - 7 May 2016
avatar wilsonge wilsonge - close - 7 May 2016
avatar wilsonge wilsonge - change - 7 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 17:12:51
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 7 May 2016

Merged - thanks @andrepereiradasilva :)

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 7 May 2016

thanks all for testing and comments!

avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 7 May 2016

Add a Comment

Login with GitHub to post a comment