No - active/current is highlited and has not been changed in this PR

On 4 May 2016 at 21:08, SharkyKZ notifications@github.com wrote:

If active/current page is meant to be in the center, line 121 needs to be
removed.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10240 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sorry, removed my comment to test a bit more.

In that case line 121 should be deleted as it causes items to shift.

Maybe I dont understand what you mean - is this different to before?

See before and after patch:

After patch, line 121 removed:

Other than only showing 5 not 10 and not showing the useless ... what is your point
maybe i am being thick i just dont get what you are saying

Added screenshots.

I saw them but i still dont understand

Patch causes an undesired effect. All items before 9 (the former ...) are removed, active item is no longer centered. This is because of a leftover statement on line 121.

Active item was NOT centered before
On 4 May 2016 9:32 pm, "SharkyKZ" notifications@github.com wrote:

Patch causes an undesired effect. All items before 9 (the former ...) are
removed, active item is no longer centered. This is because of a leftover
statement on line 121.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10240 (comment)

I applied the patch and gave it a test. It works, but without line 121 (as mentioned by @SharkyKZ) it is working much better.
In that case the active item stays 'centered' (when possible) or better: the active item stays in the same position, which is more convenient.

I will take another look to see if I "get it" now

Having looked at it with line 121 removed I see what you mean and I dont
like it for the following reason
Before this alteration
You click on 9 and 9 is highlited and your cursor is still over the 9
After this alteration
You click on 9 and 9 is highlited and your cursor is now over the 10 and
the 9 has shifted one to the left

On 5 May 2016 at 11:42, Brian Teeman brian@teeman.net wrote:

I will take another look to see if I "get it" now

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

That is the intended behavior. This patch is only meant to change ... back to a number, right?

Before

After

Line 121 removed

Closed - cant be bothered

I have just send you a pull request to remove that if line: brianteeman#22

Thanks!! I had enough coffee now and understand what has been said

I have tested this item successfully on 273898e

Works thanks

Im altering the test by @SharkyKZ as he just tested without the line 122 successfully.

RTC

I have tested this item successfully on 273898e

Tested successfully, thanks for reopening and solving.