[#10224] - add Visible by User Group column to Users: Viewing Access Levels
- Closed
- 7 May 2016
- Medium
- Build: staging
- # 10224
- Diff
- pe7er:viewing-access-levels-with-user-groups
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR adds an extra column with information to Users: Viewing Access Levels to get a better overview of what User Groups have been assigned to Having Viewing Access.
Testing Instructions
Use Joomla with Test English (GB) sample data.
Before the PR
Go to Users > Access Levels
To view the User Groups that have access to a specific Viewing Access Level,
you'll have to click each of the Viewing Access Levels.
So to see all User Groups that have access to the Viewing Access Level Special, you've to click on "Special"
After the PR
Go to Users > Access Levels
The list of Viewing Access Levels has an extra column with "Visible by User Group".
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
I have tested this item 
successfully on 56c6360
I can reproduce the issue before and after the patch.
I think it's a useful submission to the Joomla! core.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
This PR has received new commits.
CC: @hans2103
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
| Category | ⇒ | ACL UI/UX |
| Labels | |||
I think it will be better to use the existing string "User Groups Having Viewing Access" for the column heading. We have enough confusion and confusing strings for the ACL as it is
Tested successfully, nice one Pe7er !!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
This PR has received new commits.
CC: @hans2103
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
Good point @brianteeman, I've used an existing language string & removed the new one.
Thanks for testing @allrude !
I have tested this item successfully on db43a7e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
Thanks @pe7er Travis still not happy though ;(
On 4 May 2016 at 12:19, Peter Martin notifications@github.com wrote:
Good point @brianteeman https://github.com/brianteeman, I've used an
existing language string & removed the new one.Thanks for testing @allrude https://github.com/allrude !
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10224 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
This PR has received new commits.
CC: @brianteeman, @hans2103
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
No, I know.
I am not happy either as my attempts to install PHPCodeSniffer on my system have been unsuccessful so far.. :-)
I have tested this item successfully on 4c770af
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
@pe7er a recent PR has introduced a merge conflict ;(
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10224.
closed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 14:36:28 |
| Closed_By | ⇒ | brianteeman |
nice one! will test when possible