? ? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
4 May 2016

Pull Request for hhvm is out of date and segfaulting with phpunit Issue.

Summary of Changes

Use Trusty build for HHVM to get HHVM 3.13.1 which solves a segfault issue in the HHVM 3.6.x testing
use fast finish to let allow failures continue to run yet still report the completed required tests on time. (trusty builds can be slow)

Note: although this get's us testing on a supported HHVM version and solved the segfault issue, there is still a Fatal error: request has exceeded memory limit issue with a test. This test error should not hold back accepting this PR.

Testing Instructions

Merge by code review

avatar photodude photodude - open - 4 May 2016
avatar photodude photodude - change - 4 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2016
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2016
Labels Added: ? ?
avatar photodude photodude - change - 4 May 2016
The description was changed
avatar rdeutz
rdeutz - comment - 4 May 2016

@photodude do you have na idea what we can do to work around the memory limit? I assume setting the memory_limit to a high value is not the solution if possible.

avatar brianteeman brianteeman - change - 4 May 2016
Category Unit Tests
avatar brianteeman brianteeman - change - 4 May 2016
Labels
avatar wilsonge wilsonge - reference | d7a18f1 - 4 May 16
avatar wilsonge wilsonge - merge - 4 May 2016
avatar wilsonge wilsonge - close - 4 May 2016
avatar wilsonge wilsonge - change - 4 May 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-04 10:48:45
Closed_By wilsonge
Labels
avatar wilsonge wilsonge - change - 4 May 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016
avatar photodude
photodude - comment - 4 May 2016

@rdeutz I tested with the default Trusty memory limit for hhvm using ini_get("memory_limit") returns 17179869184 available and fails

Eventually I found a way to change the hhvm memory limit and set it to a lower limit then to unlimited. @andrepereiradasilva the post you referenced was my starting point (see my comment on that post), but that resulted in a different error cp: cannot create regular file. I did find a way around that
for unlimited ini_get("memory_limit") returns 9223372036854775807
And that still fails.

In all cases memory_get_peak_usage() returns 2097152

The Test causing Fatal error: request has exceeded memory limit in /home/travis/build/photodude/joomla-cms/libraries/vendor/phpunit/php-timer/src/Timer.php on line 97 is 'FinderIndexerStemmerPorter_EnTest::testStemWrongLanguage'"

I since I used --debug with phpunit to acquire a list of tests (an incomplete list) that errored or failed.
You can get that list in issue #10220
I have reported the slow builds with Trusty to Travis-CI travis-ci/travis-ci#5980

I'm trying to see if there is a way to skip the tests having issues so we can get a report of the other issues. So far the --exclude-group didn't work (even with adding the @group to the failed test).

Add a Comment

Login with GitHub to post a comment