? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
3 May 2016

Pull Request for Improvement.

Summary of Changes

This PR is a proposal to make a better visual to the trees in the list views of isis.

If accepted i can do in the other tree views (tags, menu items, etc).

As you can see from the code difference is just one line of code that changes.

Before PR (current scenario)

image

After PR (proposed scenario)

image

Testing Instructions

  1. Use latest staging (the difference is more visible)
  2. Apply patch
  3. Go to content categories and check the visual difference
  4. Do also some searches (with and without patch to check the difference)
avatar andrepereiradasilva andrepereiradasilva - open - 3 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 3 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 May 2016
Category Components UI/UX
avatar brianteeman
brianteeman - comment - 3 May 2016

Not convinced myself that this is any better than the current option. I
find that as the symbol looks like a letter L my eyes try to read it.

On 3 May 2016 at 14:45, andrepereiradasilva notifications@github.com
wrote:

Pull Request for Improvement.
Summary of Changes

This PR is a proposal to make a better visual to the trees in the list
views of isis.

If accepted i can do in the other tree views (tags, menu items, etc).

As you can see from the code difference is just one line of code that
changes.
Before PR (current scenario)

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14984924/1e3146f2-113d-11e6-8782-1528e84ea7a8.png
After PR (proposed scenario)

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14984919/1a8e8190-113d-11e6-8372-425be9e6e13f.png
Testing Instructions

  1. Use latest staging (the difference is more visible)
  2. Apply patch
  3. Go to content categories and check the visual difference
  4. Do also some searches (with and without patch to check the difference)

You can view, comment on, or merge this pull request online at:

#10213
Commit Summary

  • cleaner tree

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10213

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 May 2016

we can add another symbol.
The main propose of this is to better understand the tree view and it's levels just by looking.

avatar brianteeman
brianteeman - comment - 3 May 2016

I understand the aim - I was just pointing out an issue (for me) with the
chosen symbol

On 3 May 2016 at 15:25, andrepereiradasilva notifications@github.com
wrote:

we can add another symbol.
The main propose of this is to better understand the tree view and it's
levels.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10213 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 3 May 2016

What do you think about changing your three vertical dots with a dash or even an elipsis (love the muted class you are using) and then using ↳ ↳


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 May 2016

ok! will give it another try when i have time.

avatar BurtNL BurtNL - test_item - 4 May 2016 - Tested successfully
avatar BurtNL
BurtNL - comment - 4 May 2016

I have tested this item :white_check_mark: successfully on 28ffdc3

Tested, works as described. The view has become clearer to me.
Looking forward to the setup as proposed by @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016

well i think it's a matter of taste.

some examples:

image

image

image

image

avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016

i prefer the last one because it's cleaner.

avatar BurtNL
BurtNL - comment - 4 May 2016

I agree with @andrepereiradasilva, I prefer the last example too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar pe7er
pe7er - comment - 8 May 2016

Great! Thanks @andrepereiradasilva, this is a huge UX improvement!

IMHO this version is the most clear one:
Category-overview


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

lol, each one likes a different one.
I think this is going to have to be a PLT decision.

The goal is to apply this to all the items with tree structures (menus, access level, tags, categories, etc) so we can have a consistent tree structure across all views.

pinging @wilsonge for a decision.

avatar brianteeman brianteeman - change - 8 May 2016
Status Pending Needs Review
avatar brianteeman
brianteeman - comment - 8 May 2016

Set to Needs Review - not sure if its PLT or UI team on this one


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar wilsonge
wilsonge - comment - 8 May 2016

I prefer the last one (i.e. https://cloud.githubusercontent.com/assets/9630530/15011868/1e7a8592-11ec-11e6-9e4e-69e91f4a7292.png) - I think the arrows Brian proposed are not rendering consistently between platforms (I can see large differences between windows and mac). So I think this is the next best solution

avatar andrepereiradasilva
andrepereiradasilva - comment - 8 May 2016

is that a opinion or a decision?

avatar brianteeman
brianteeman - comment - 16 May 2016

I think I agree with @wilsonge

Can you update the PR to use that styling so it can be tested in real life


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

yes, once i remember the character i used for the dash :wink:

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 May 2016

This PR has received new commits.

CC: @BurtNL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

ok done

avatar brianteeman
brianteeman - comment - 16 May 2016

Are you sure thats the correct symbol the dash looks very narrow
screen shot 2016-05-16 at 16 46 32


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

hum Mac right?
in Windows
image

avatar brianteeman
brianteeman - comment - 16 May 2016

yes - a mac ;)

On 16 May 2016 at 22:50, andrepereiradasilva notifications@github.com
wrote:

hum Mac right?
in Windows
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15305025/9f136ebe-1bb8-11e6-85e8-da0ccb4da20c.png


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10213 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar joomla-cms-bot
joomla-cms-bot - comment - 16 May 2016

This PR has received new commits.

CC: @BurtNL


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 May 2016

is ok now?

avatar brianteeman brianteeman - test_item - 16 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 16 May 2016

I have tested this item :white_check_mark: successfully on e0d3450


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar brianteeman
brianteeman - comment - 16 May 2016

Yes thats it - screenshot for reference

screen shot 2016-05-16 at 17 02 35


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 May 2016

ok @wilsonge, so do we have an ok on this tree view?

avatar wilsonge
wilsonge - comment - 17 May 2016

Yes :)

avatar andrepereiradasilva
andrepereiradasilva - comment - 17 May 2016

ok then, so when this gets tested and eventually merged i will do PR for the others tree like structures (tags, menus and user groups).

avatar MATsxm MATsxm - test_item - 17 May 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 17 May 2016

I have tested this item :white_check_mark: successfully on e0d3450

Like this way :+1: - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.

avatar wilsonge wilsonge - change - 17 May 2016
Milestone Added:
avatar wilsonge wilsonge - reference | 3b8e664 - 17 May 16
avatar wilsonge wilsonge - merge - 17 May 2016
avatar wilsonge wilsonge - close - 17 May 2016
avatar wilsonge wilsonge - change - 17 May 2016
Status Needs Review Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-17 12:02:39
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 May 2016
avatar wilsonge wilsonge - merge - 17 May 2016
avatar wilsonge
wilsonge - comment - 17 May 2016

You'd better get moving then :) Merged with two good tests!

avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 17 May 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 17 May 2016

no pressure right? ;)

Add a Comment

Login with GitHub to post a comment