? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
2 May 2016

Pull Request for New Issue.

Summary of Changes

After latest merging the state filter stop working in hathor.

This is because of the input filters that i forgot to change.
The state filter cannot be filtered by 'int' because it contains * for All so it was to be filtered 'string' (the same in other views for the language filter and other filters).

Don't know how it works on isis but on hathor doesn't work without this change.

There are some others with the same problem. Will make PR to correct them.

Testing Instructions

Code review, or:
1. Apply patch
2. Use hathor and select filter "All" in the state filter in the banners clients view.

avatar andrepereiradasilva andrepereiradasilva - open - 2 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 2 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 2 May 2016
The description was changed
avatar brianteeman brianteeman - change - 2 May 2016
Category Components UI/UX
avatar brianteeman brianteeman - test_item - 2 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 May 2016

I have tested this item :white_check_mark: successfully on d22a9a3


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10188.

avatar grhcj grhcj - test_item - 3 May 2016 - Tested successfully
avatar grhcj
grhcj - comment - 3 May 2016

I have tested this item :white_check_mark: successfully on d22a9a3


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10188.

avatar brianteeman brianteeman - change - 3 May 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 3 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10188.

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 May 2016
Milestone Added:
avatar infograf768
infograf768 - comment - 3 May 2016

this is a bug introduced recently. milestone should be 3.6.0 imho

avatar brianteeman
brianteeman - comment - 3 May 2016

It was a fat finger

avatar brianteeman brianteeman - change - 3 May 2016
Milestone Added:
avatar brianteeman brianteeman - change - 3 May 2016
Milestone Removed:
avatar rdeutz rdeutz - close - 3 May 2016
avatar rdeutz rdeutz - merge - 3 May 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 May 2016
avatar rdeutz rdeutz - change - 3 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-03 17:12:28
Closed_By rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment