[#10183] - __DEPLOY_VERSION__
- Fixed in Code Base
- 3 May 2016
- Medium
- Build: staging
- # 10183
- Diff
- zero-24:patch-7
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
https://github.com/joomla/joomla-cms/search?utf8=%E2%9C%93&q=+__DEPLOY_VERSION__&type=Code
Testing Instructions
Nothing to test as it is just a doc block change!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@andrepereiradasilva yes see: https://developer.joomla.org/news/644-version-number-shifting.html
@roland-d I'm not sure what you mean? The __DEPLOY_VERSION__ string is a placesholder the framework use to set the correct version on time of the release.
But the CMS don't use this kind of automation. This is the last i know. Maybe @mbabker can help.
I have tested this item 
successfully on 19dad0c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10183.
BTW shouldn't it be 3.6.0 instaead of 3.6. Is there any rule for that?
brianteeman
- | Title |
|
||||||
| Category | ⇒ | Code style Documentation |
There isn't a rule on whether it's just major.minor or if it's major.minor.patch. The CMS has mainly used the former while the Framework ends up using the latter because the job that creates the release tag runs this command and uses the user's input version number:
find . -name "*.php" -type f -exec sed -i "s/__DEPLOY_VERSION__/$Version/g" "{}" \; -exec git add {} \;The CMS doesn't have a fully automated job like that and IMO it shouldn't either for reasons not relevant to this discussion.
All clear, I was just wondering :)
We have as of recently in build/bump.php - but that's for another PR.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-03 15:20:41 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
i was about to do this. Thanks.
But will 3.6 be the next version?