? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
1 May 2016

Summary of Changes

Simple PR to add the search tooltip and element label (accessibility) in com_finder.

Testing Instructions

Code review, or:
1. Apply patch
2. Go to Components -> Smart Search -> Indexed Content, check the tooltip in the search field.
3. Go to Components -> Smart Search -> Content Maps, check the tooltip in the search field.
4. Go to Components -> Smart Search -> Search Filters, check the tooltip in the search field.

avatar andrepereiradasilva andrepereiradasilva - open - 1 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 1 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Added: ? ?
avatar RonakParmar
RonakParmar - comment - 2 May 2016

@andrepereiradasilva Sorry, but I am not able to see any changes before and after patch applied, Can you please provide some more information regarding changes of the PR.
System Information:
Joomla Version: Joomla! 3.5.0-beta Beta [ Ember ] 06-November-2015 24:00 GMT
PHP Version: 5.4.45-3+deb.sury.org~precise+1
Database Version: 5.5.49-0ubuntu0.12.04.1
Web Server: Apache/2.2.22 (Ubuntu)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar RonakParmar
RonakParmar - comment - 2 May 2016

Hi,
I am not able see any tooltip on "Indexed Content" and "Search Filters" views of com_finder component.
On "Content Maps" view I can see "Search in content map title." tooltip on mouse-over of search-box.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar brianteeman brianteeman - change - 2 May 2016
Category Components Language & Strings UI/UX
avatar brianteeman brianteeman - change - 2 May 2016
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 May 2016

@RonakParmar are you using latest staging? There have been a lot of changes recently.

avatar brianteeman brianteeman - test_item - 2 May 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 2 May 2016

I have tested this item :red_circle: unsuccessfully on c9330dd

same results as @RonakParmar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 May 2016

strange, will check later

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 May 2016

@brianteeman @RonakParmar just tested again in latest staging.

It's working fine. please check code difference to see the changes that should exist after PR.

avatar brianteeman brianteeman - test_item - 2 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 May 2016

I have tested this item :white_check_mark: successfully on c9330dd

No idea what was wrong before. I probably needed more cafeine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar grhcj grhcj - test_item - 2 May 2016 - Tested successfully
avatar grhcj
grhcj - comment - 2 May 2016

I have tested this item :white_check_mark: successfully on c9330dd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar brianteeman brianteeman - change - 2 May 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 2 May 2016

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10181.

avatar joomla-cms-bot joomla-cms-bot - change - 2 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 3 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-03 07:15:11
Closed_By rdeutz
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment