? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
1 May 2016

Summary of Changes

Simple PR to improve the search tooltip and element label (accessibility) in com_installer.

Testing Instructions

Code review, or:
1. Apply patch
2. Go to Extensions -> Manage -> Update, check the tooltip in the search field.
3. Go to Extensions -> Manage -> Manage, check the tooltip in the search field.
4. Go to Extensions -> Manage -> Discover, check the tooltip in the search field.
5. Go to Extensions -> Manage -> Install Languages, check the tooltip in the search field.
6. Go to Extensions -> Manage -> Update Sites, check the tooltip in the search field.

avatar andrepereiradasilva andrepereiradasilva - open - 1 May 2016
avatar andrepereiradasilva andrepereiradasilva - change - 1 May 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 May 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 1 May 2016
Category Components Language & Strings UI/UX
avatar brianteeman brianteeman - change - 1 May 2016
Labels
avatar brianteeman
brianteeman - comment - 1 May 2016

Added some inline comments about en-gb strings

avatar andrepereiradasilva andrepereiradasilva - change - 1 May 2016
Labels
avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

done

avatar brianteeman brianteeman - test_item - 1 May 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 1 May 2016

I have tested this item :red_circle: unsuccessfully on 30ac607

Manage
search by ID doesnt work

Discover
search by ID doesnt work

Update sites
search by ID doesnt work


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar joomla-cms-bot
joomla-cms-bot - comment - 1 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar andrepereiradasilva
andrepereiradasilva - comment - 1 May 2016

test now please. It was not working (bug) before this PR.

avatar brianteeman brianteeman - test_item - 1 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 1 May 2016

I have tested this item :white_check_mark: successfully on e5ade7f


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 May 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 May 2016

nice spoted @grhcj ! fixed

avatar grhcj grhcj - test_item - 3 May 2016 - Tested successfully
avatar grhcj
grhcj - comment - 3 May 2016

I have tested this item :white_check_mark: successfully on e161b6d

Completed testing on code review (only string changes)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 May 2016

@brianteeman RTC? the only think changed since your test is the removal of the extra ":". e161b6d

avatar brianteeman brianteeman - test_item - 3 May 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 May 2016

I have tested this item :white_check_mark: successfully on e161b6d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar brianteeman brianteeman - change - 3 May 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 3 May 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10174.

avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 4 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-04 07:08:56
Closed_By rdeutz
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment