Seems strange to search for the author on a category as a category doesnt
really have an author

On 30 April 2016 at 16:11, andrepereiradasilva notifications@github.com
wrote:

Summary of Changes

Simple PR to improves the search tooltip and element label (accessibility)
in com_categories.
Testing Instructions

Code review, or:
1. Apply patch

2. Go to Content -> Categories, check the tooltip in the search field.

You can view, comment on, or merge this pull request online at:

#10145
Commit Summary

• complete tooltip
• category

File Changes

• M administrator/components/com_categories/models/forms/filter_categories.xml https://github.com/joomla/joomla-cms/pull/10145/files#diff-0 (3)
• M administrator/language/en-GB/en-GB.com_categories.ini https://github.com/joomla/joomla-cms/pull/10145/files#diff-1 (3)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/10145.patch
• https://github.com/joomla/joomla-cms/pull/10145.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10145

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

i think it does (created_user_id in #__categories).

Anyway, check what search the categories model does: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/models/categories.php#L231-L247

Yes I know that the code works - but its just strange. Categories have a
creator not an author and we never display the value of that anywhere so I
just dont see why you would want to search on this. I would personaly
prefer removing that part of the code

(Content also supports searching by author and it is very relevant there
and also missing from the tooltip)

On 30 April 2016 at 16:27, andrepereiradasilva notifications@github.com
wrote:

i think it does (created_user_id in #__categories).

Anyway, check what search the category model does:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/models/categories.php#L231-L247

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10145 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Yes I know that the code works - but its just strange. Categories have a creator not an author and we never display the value of that anywhere so I just dont see why you would want to search on this. I could personaly prefer removing that part of the code

Don't forget com_categories is a horizontal component (used with other components) that is used in third party extensions and those may or may not use the author:.

Also a creator, IMO, is the author of that category, so i see no problems.

(Content also supports searching by author and it is very relevant there and also missing from the tooltip)

yeah, i know. another PR for com_content ...

I have tested this item successfully on 2dda816

I have tested this item successfully on 2dda816

thanks

RTC

Agree with Brian on the Author for categories topic, this seems wrong, a category is an element for structure content so an being a creator of a category isn`t the same as an author. Anyway this PR only reflects the situation we have ow so I am merging it. But I think we should change it.

I created #10150 as an issue to remind about removing the author search

On 30 April 2016 at 19:05, Robert Deutz notifications@github.com wrote:

Merged #10145 #10145.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10145 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/