? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
30 Apr 2016

Summary of Changes

Insted of the hardcoded english writable & NOT writable we now use the language constants:

COM_ADMIN_WRITABLE & COM_ADMIN_UNWRITABLE that we also use for the GUI in the text download too. The JSON Output handed it different and should not changed.

Testing Instructions

  • Go to the System Information
  • Use the system Information Download button for text
  • see that we have on the directory secten have allways writable & NOT writable
  • apply this patch
  • try it again
  • see that we now have the same textes as we have in the GUI
avatar zero-24 zero-24 - open - 30 Apr 2016
avatar zero-24 zero-24 - change - 30 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 30 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

I have tested this item :white_check_mark: successfully on b388514


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10142.

avatar brianteeman
brianteeman - comment - 30 Apr 2016

Not sure this is a good idea. The objective of the download sysinfo is to
submit it at support sites such as forum.joomla.org so translating strings
might make it less usable

avatar roland-d
roland-d - comment - 30 Apr 2016

I agree with Brian here, I don't think this is a good idea. If you get an output from a system whose language you do not speak, it makes support more difficult. English is generally understood so I don't see a problem having hardcoded strings here.

avatar andrepereiradasilva
andrepereiradasilva - comment - 30 Apr 2016

don't agree brian.

you could ask users to submit the english version.

it's good for other language support forums and extensions

avatar zero-24
zero-24 - comment - 30 Apr 2016

Cosing

avatar zero-24 zero-24 - change - 30 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-30 12:39:19
Closed_By zero-24
avatar zero-24 zero-24 - close - 30 Apr 2016

Add a Comment

Login with GitHub to post a comment