? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Apr 2016

Since the change in core to ajaxify the Calculated settings there is no longer a need for the second bullet point in the notes below the rules. This PR removes point 2 and as we now only have one note removes the number from point 1.

Summary of Changes

Before

JLIB_RULES_SETTING_NOTES="1. Changes apply to this component only.
Inherited - a Global Configuration setting or higher level setting is applied.
Denied always wins - whatever is set at the Global or higher level and applies to all child elements.
Allowed will enable the action for this component unless it is overruled by a Global Configuration setting.

2. Select Save to refresh the calculated settings."

After

JLIB_RULES_SETTING_NOTES="Changes apply to this component only.
Inherited - a Global Configuration setting or higher level setting is applied.
Denied always wins - whatever is set at the Global or higher level and applies to all child elements.
Allowed will enable the action for this component unless it is overruled by a Global Configuration setting"

avatar brianteeman brianteeman - open - 28 Apr 2016
avatar brianteeman brianteeman - change - 28 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 28 Apr 2016
Labels
Easy No Yes
avatar brianteeman brianteeman - change - 28 Apr 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 28 Apr 2016
Labels
avatar MATsxm MATsxm - test_item - 28 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 28 Apr 2016

I have tested this item :white_check_mark: successfully on d906033

on review - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar BurtNL
BurtNL - comment - 2 May 2016

Is the dot missing at the end of the last line, after 'setting'?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar brianteeman
brianteeman - comment - 2 May 2016

Not in the code just in the example

avatar zero-24 zero-24 - test_item - 7 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on d906033

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2016

This PR has received new commits.

CC: @MATsxm, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar Kubik-Rubik Kubik-Rubik - test_item - 7 May 2016 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on 0094c74

Thank you @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar zero-24
zero-24 - comment - 7 May 2016

I have just send you a PR to fix the merge conflicts and comment on two missing lines.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2016

This PR has received new commits.

CC: @Kubik-Rubik, @MATsxm, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2016

This PR has received new commits.

CC: @Kubik-Rubik, @MATsxm, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2016

This PR has received new commits.

CC: @Kubik-Rubik, @MATsxm, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot
joomla-cms-bot - comment - 7 May 2016

This PR has received new commits.

CC: @Kubik-Rubik, @MATsxm, @zero-24


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar zero-24 zero-24 - test_item - 7 May 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on cef87e5

:smile: :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar Kubik-Rubik Kubik-Rubik - test_item - 7 May 2016 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 7 May 2016

I have tested this item :white_check_mark: successfully on cef87e5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar brianteeman brianteeman - change - 7 May 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 7 May 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10115.

avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 May 2016
Milestone Added:
avatar wilsonge wilsonge - change - 7 May 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-05-07 19:40:38
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 2080557 - 7 May 16
avatar wilsonge wilsonge - merge - 7 May 2016
avatar wilsonge wilsonge - close - 7 May 2016
avatar brianteeman brianteeman - head_ref_deleted - 8 May 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 8 Jun 2016

Folks, this has proved wrong.
Ajax does not always save correctly the New and Calculated settings.
One case when one changes the permissions for a Parent group and then switches to the child group without saving first.
An other case, as explained here:
#10755

I guess we should revert this.

Add a Comment

Login with GitHub to post a comment