? Success

User tests: Successful: Unsuccessful:

avatar RoterNagel
RoterNagel
25 Apr 2016

Pull Request for Issue # .

Summary of Changes

The logo in the header has a new max-height instead of max-width. Before the changes a huge logo changed the appearance of the followiing elements.
old-header-logo_042516_063757_pm_042516_070611_pm

Now the logo doesn't influence the content after it because it's not possible that the logo is to high.
new-header-logo_042516_070433_pm

Testing Instructions

Go to Extensions > Templates > Styles click at isis-Default.
Tab "Advanced" > Logo
Use a logo with a height over 36px, for example 150px.

Logo shouldn't change the height of the content after it because it shouldn't float underneath the following content.

avatar RoterNagel RoterNagel - open - 25 Apr 2016
avatar RoterNagel RoterNagel - change - 25 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 Apr 2016
Category Templates (admin)
avatar brianteeman brianteeman - test_item - 25 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Apr 2016

I have tested this item :white_check_mark: successfully on 0d72090


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10089.

avatar MATsxm MATsxm - test_item - 25 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 25 Apr 2016

I have tested this item :white_check_mark: successfully on 0d72090

Able to reproduce then #10089 works as decribed - Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10089.

avatar brianteeman brianteeman - change - 25 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 25 Apr 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10089.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 25 Apr 2016
Milestone Added:
avatar rdeutz rdeutz - reference | eec9d27 - 26 Apr 16
avatar rdeutz rdeutz - merge - 26 Apr 2016
avatar rdeutz rdeutz - close - 26 Apr 2016
avatar rdeutz rdeutz - change - 26 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-26 10:38:11
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Apr 2016
avatar rdeutz rdeutz - merge - 26 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 26 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2016
Labels Removed: ?
avatar RoterNagel RoterNagel - head_ref_deleted - 26 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment