[#10087] - Build query only if 'select' and 'from' attributes are set and don't execute blank query
- Fixed in Code Base
- 4 Aug 2017
- Medium
- Build: staging
- # 10087
- Diff
- izharaazmi:patch-10
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
The new implementation of JFormFieldSQL that supports Joomla query builder format should not generate any query if the parameters are not sufficient in the field element. However it builds a blank query SELECT FROM anyway that causes error.
Testing Instructions
Load a form with following field definition (note the missing query attribute):
<field
name="sql_test"
type="sql"
>
<option value="none">None</option>
</field>Without this patch there is a mysql error.
After patch there is a list with single option taken from xml definition only.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Fields Libraries |
Can we have some test here please.
I have tested this item
Followed test instructions and works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10087.
@izharaazmi shouldn't this PR be updatet cause Installation shows 3.6-Design?
| Status | Pending | ⇒ | Information Required |
Pardon me. I didn't get you.
sorry, i would ask: Can i test this PR on these Settings:
System information
3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 53 (64-bit)
MAMP 4.1.1
- PHP 7.0.15
- MySQLi 5.6.35
I have tested this item
Tested unsuccessfully on latest staging.
- In Custom Fields
- In Article View override
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10087.
I have tested this item
Sorry i tested wrong...
test successful.
It breaks in Custom Fields when you build a query "SELECT FROM" - but i guess it´s another issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/10087.
@coolcat-creations can you please open an Issue about "breaks custom Fields"?
| Status | Information Required | ⇒ | Ready to Commit |
RTC after two successful tests.
@izharaazmi can you have a look at the conflicts, thanks
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have just removed the label
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-04 12:19:29 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Removed:
Conflicting Files
|
||
There is a single test case defined for this class. Where and how should I add another failing test case? Please advise.