Pending

User tests: Successful: Unsuccessful:

avatar crperk44
crperk44
18 Apr 2013

Please ingore, wrong branch

avatar crperk44 crperk44 - open - 18 Apr 2013
avatar nicksavov
nicksavov - comment - 19 Apr 2013

Hi and welcome, crperk44!

Looks like you may have pulled to the wrong repo. Did you mean to submit this for Joomla 2.5?

avatar crperk44
crperk44 - comment - 19 Apr 2013

On the advice of Brian Teeman I opened https://github.com/joomla/joomla-cms, where I found 4 branches
1) 2.5.x
2) master (=3.0)
3) staging (=???)
4) v2.5.2
Since I tested my fix on 2.5.9 sites the first one seemed to me the most logical choice.
If that is not correct I have no idea where you have hidden 2.5?

avatar nicksavov
nicksavov - comment - 19 Apr 2013

Yes, that's correct. 2.5.x is the 2.5 one, but you sent the pull request to master. Try sending it to 2.5.x instead.

Hope this helps!

avatar elinw
elinw - comment - 20 Apr 2013

To select a branch to send the patch to, when the pull request is made you'll see that by default is says master, but that is actually a drop down and you can select 2.5.x.

avatar crperk44
crperk44 - comment - 20 Apr 2013

I had selected the 2.5.x, no idea why I ended up in master (3.0)?
How can I delete the fix I proposed?

After spending a week installing eclipse, git, github, wrestling through incomprehensible documentation abundant in 3 character acronyms, SVN, CDN, PDT, SDK, each pointing back to the other, ever heard of Catch-22?

avatar nicksavov
nicksavov - comment - 21 Apr 2013

Hang in there. You'll get the hang of things.

Looks like you figured things out for closing. Now just send another pull request, but make sure you select the 2.5.x branch before submitting the pull request. See this image:
http://docs.joomla.org/File:Git-coders-tutorial-20121009-12.png

Hope this help!

Add a Comment

Login with GitHub to post a comment