I have tested this item successfully on cb080d9

Content maps are intended to be "flat" and we have no immediate plans to make them hierarchical. So Max Levels cannot be greater than 2.

nice thanks!

You have made a language string change but I didnt find yet where that is used

# egrep -R "COM_FINDER_ITEM_X_ONLY" /path/to/joomla-staging/
/path/to/joomla-staging/administrator/language/en-GB/en-GB.com_finder.ini:COM_FINDER_ITEM_X_ONLY="%s Only"
/path/to/joomla-staging/administrator/components/com_finder/helpers/html/finder.php:                       $string = JText::sprintf('COM_FINDER                                                    _ITEM_X_ONLY', JText::_($key));
/path/to/joomla-staging/administrator/components/com_finder/helpers/html/finder.php:                       $string = JText::sprintf('COM_FINDER                                                    _ITEM_X_ONLY', JText::_($key));
/path/to/joomla-staging/administrator/components/com_finder/helpers/html/finder.php:               $options[] = JHtml::_('select.option', '1',                                                     JText::sprintf('COM_FINDER_ITEM_X_ONLY', JText::_('JPUBLISHED')));
/path/to/joomla-staging/administrator/components/com_finder/helpers/html/finder.php:               $options[] = JHtml::_('select.option', '0',                                                     JText::sprintf('COM_FINDER_ITEM_X_ONLY', JText::_('JUNPUBLISHED')));

The Branches filter

UPDATE: Actually now that i see it it's better no not chnage it and not use it at all...

I know how to use grep ;)

I am looking for the real world example of the strong being used

eheheh

The "[...] Only" is used at least here:

Thanks - I see it now. Which brings the question why is that a plural. The branch is singular isnt it? @chrisdavenport

The top-level branch name should be the singular form since that is used in the query "language" where it makes sense. For consistency, I agree that it would make sense for the drop-down to also use the singular forms.

I've been giving this a little thought and I think that "map group" would be a better term than "branch" in this context. We already refer to the page as "Content Maps" so I think we should reinforce that term rather than introducing any new ones.

I'm thinking that the page should show a list with columns "Status", "Title", "Maps" and "Content items". The drop-down "Select branch" becomes "Select map group". The column "Maps" contains the number of maps within the map groups (this is something that was dropped in this PR, but is actually quite useful). The column "Content items" replaces "Nodes".

Can you post that in the en-gb issues and I will take a look at it there.
Shouldn't effect this PR.
On 24 Apr 2016 5:31 pm, "Chris Davenport" notifications@github.com wrote:

The top-level branch name should be the singular form since that is used
in the query "language" where it makes sense. For consistency, I agree that
it would make sense for the drop-down to also use the singular forms.

I've been giving this a little thought and I think that "map group" would
be a better term than "branch" in this context. We already refer to the
page as "Content Maps" so I think we should reinforce that term rather than
introducing any new ones.

I'm thinking that the page should show a list with columns "Status",
"Title", "Maps" and "Content items". The drop-down "Select branch" becomes
"Select map group". The column "Maps" contains the number of maps within
the map groups (this is something that was dropped in this PR, but is
actually quite useful). The column "Content items" replaces "Nodes".

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10068 (comment)

Good idea, although I'd like to see the maps count re-introduced in the PR.

OK @andrepereiradasilva please put the count back and we will discuss the language strings in the user interface group

put the count back

What count?

by "count" do you mean the level 1 count?

I remvoed it because this way is more in line with other views (don't have tree subitems count).

but ok i will put it. and put singular forms in the filters.
The rest will leave for discussion in joomla/user-interface-text#58 for another PR perhaps.

@andrepereiradasilva Thanks. That count can be quite useful, especially when debugging a search plugin. Sometimes the number can be in the hundreds so it would be a bit tedious to count them by hand. ;-)

This PR has received new commits.

CC: @chrisdavenport

This PR has received new commits.

CC: @chrisdavenport

done

BTW @chrisdavenport i don't understand much of the com_finder. never used it myself.
Can you enlighten me? why does exist a branch "Category" and then a "Category" inside the branch "Type"?

This PR has received new commits.

CC: @chrisdavenport

This PR has received new commits.

CC: @chrisdavenport

This PR has received new commits.

CC: @chrisdavenport

conflicts fixed.

@chrisdavenport @brianteeman Please retest so we finish the com_finder searchtools review (this is the only one missing).

The terms we can change in another PR when decided.

I have tested this item successfully on 1b99d5a

This is fine for now, but as noted, the terminology should be reviewed.

Good work.

RTC