[#10062] - Solve issues with item state dropdowns
- Fixed in Code Base
- 30 Apr 2016
- Medium
- Build: staging
- # 10062
- Diff
- andrepereiradasilva:correct-dropdowns
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
As refered in #10056, there are some bugs in the current implementations of the dropdown box in state column.
Doesn't check if the user can change the item state
The dropdown is currently generated based on the
- Select Status -filter state and not on the item state, as it should.
This creates some problems, for instance, if you select, in the state filter, "All", an item in a trashed state has a trash option ... similiar, an article in archived state has the archive option.
This PR corrects this two bugs in all this views:
- com_content articles
- com_content featured
- com_contact contacts
- com_newsfeeds newsfeeds
- com_banners banners
- com_banners clients
- com_modules modules
Testing Instructions
- Apply patch
- Test the dropdowns with all states in this views.
Note: You can check by the code changes that the code changes are the same in all views (except the modules that have a "Duplicate" and don't have archived)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
I have tested this item 
successfully on b6b4039
@andrepereiradasilva Thanks for the PR.
One suggestion, It would be good if you change "Unarchive" text to "Unpublish" and change related icon, because on click of "Unarchive" option it will unpublish the selected item. Otherwise PR works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10062.
One suggestion, It would be good if you change "Unarchive" text to "Unpublish" and change related icon, because on click of "Unarchive" option it will unpublish the selected item. Otherwise PR works fine.
I agree with that, but it seems that some resistence to that change exists. With that in mind, in this PR i concentrated in resolving the bugs. In conclusion, that would be clearly another PR.
@andrepereiradasilva Okay thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10062.
I have tested this item successfully on b6b4039
At this point, works as described - Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10062.
@brianteeman can we have a RTC here?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
thanks and thanks for testing @MATsxm @RonakParmar
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-30 13:24:42 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@brianteeman this is what i meant in the other PR.