I have tested this item successfully on b055d84

If you look at com_content as an example you will see that this is not correct. You do not need to have publish and unpublish as they are achieved by selecting the button. You do however need archive and trash.

actually, i analysed com_content implementation and i think there are some problems:

1. Doesn't check if the user can change the item state
2. The buttons are based on the filters states an not on the item state. this creates some problems (make the filter All and you can check an article in trash state has trash option ... similiar an article in archived state has archive option)
3. There is no one click way to pass from archive to publish. You have to unarchive, that will put the item Unpublished and them Publish it.

See https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/views/articles/tmpl/default.php#L136-L150

Because of this issues, proposed a new implementation here.
Advantages:

1. Checks if the user can change the state of the item
2. The buttons are based on the item state, basicly all actions that are not the current item state appear.
3. Allows a one click way to pass from archive to publish (just like you do if you check the item and press "Publish" button)

If this is of for you i can do it in other views after this PR.

This dropdown was specifically done for accessibility I would not be in
favour in a change of this behaviour

On 23 April 2016 at 11:01, andrepereiradasilva notifications@github.com
wrote:

actually, i analysed com_content implementation and i think there are some
problems:

1. doesn't check if the user can change the sate
2. The buttons are based on the filters states an not on the item state. this creates some problems (make the filter All and you can check an article in trash state has trash option ... similiar an article in archived state has archive option)
3. There is no one click way to pass from archive or trash to publish

See
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/views/articles/tmpl/default.php#L136-L150

Because of this issues, proposed a new implementation here.
Advantages:

1. Checks if the user can change the state
2. The buttons are based on the item state, basicly all action that not the current item state appear.
3. Allows a one click way to pass from archive or trash to publish

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10056 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This dropdown was specifically done for accessibility

ok, but it's also very useful has it enables to change the state of the item in one click. instead of checking and then click the button.

I would not be in favour in a change of this behaviour

I would. It makes a lot more sense for me.
But ok, for the time being i can follow the content behaviour but without it's bugs described in "1." and "2.".

You should also know that everytime we have tried to introduce any type of
functionality where options are not available because of a state it has
been rejected by luddites

On 23 April 2016 at 11:16, andrepereiradasilva notifications@github.com
wrote:

This dropdown was specifically done for accessibility

ok, but it's also very useful has it enables to change the state of the
item in one click. instead of checking and then click the button.

I would not be in favour in a change of this behaviour

I would. It makes a lot more sense for me.
But ok, for the time being i can follow the content behaviour but without
it's bugs described in "1." and "2.".

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10056 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

This PR has received new commits.

CC: @richard67

I have tested this item successfully on 11d2282

I have tested this item successfully on 11d2282

@andrepereiradasilva Hmm, your new screenshot shows "Archive" and "Publish" in the dropdown, but according to the discussion with @brianteeman above, as far as I understood, it should be "Archive" and "Trash", and this is what I get when testing. It is also consistent with the behavior in the articles list view. I assume this was what was intended ans set my test result to "success".

it should be "Archive" and "Trash", and this is what I get when testing. It is also consistent with the behavior in the articles list view. I assume this was what was intended ans set my test result to "success".

I replicated exactly the com_content way, without the bugs

I know, but then your screenshot is wrong.

Ah, no, is correct: It is a trashed item where it belongs to. Maybe I need glasses?

no, it isn't works like this:

• item state = published: Archive; Trash
• item state = unpublished: Archive; Trash
• item state = archived: Unarchive (aka unpublished ...); Trash
• item state = trashed: Archive; Publish

I know, it doesn't make a lot of sense to me either... but it is the way com_content is right now.

ups i see you already commented.

RTC

I have set it to 3.6 as I think @rdeutz will say this is a new feature and not a bug fix

Yes, this is some kind of predictable.

tempted to merge it in 3.5.2 but ... no :-)