[#10054] - Remove label tag margins if inside tables
- Fixed in Code Base
- 23 Apr 2016
- Medium
- Build: staging
- # 10054
- Diff
- andrepereiradasilva:table-label-bottom-margin
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
The label tags inside the tables have a 5px margin where they shouldn't.
This small PR corrects that.
Before
After
Testing Instructions
Very simple test.
Code review or:
1. Use latest staging
2. Go to Extensions -> Manage -> Install languages (or any view that have labels inside table rows), Compare the margin above the language name and the margin below.
3. Apply patch
4. The extra spacing is removed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (admin) |
Are you sure this is specific enough
in isis all label inside table? I think so.
Tables should never be used for design purposes so label inside tables in isis only in this cases i think.
I have tested this item 
successfully on 0b8ccdf
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10054.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-23 12:39:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 0b8ccdf
Are you sure this is specific enough
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10054.