[#10050] - Remove extra spacing caused by paragraphs inside tables (part 1 - articles)
- Fixed in Code Base
- 23 Apr 2016
- Medium
- Build: staging
- # 10050
- Diff
- andrepereiradasilva:patch-6
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
The Created by alias in com_content articles view is using a p tag inside the results table.
The usage of padds an extra spacing to the bottom of the row.
Before patch
After patch
Testing Instructions
Very simple
- To Content -> Articles
- Check the row bottom spacing of an article with created by user alias
- Apply patch
- Repeat step 2. the space is gone.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components UI/UX |
@andrepereiradasilva the div elemet by which you replaced the p element is also a block element, see here: http://www.w3schools.com/html/html_blocks.asp.
So if p is not allowed, then div is also not allowed I assume.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.
@andrepereiradasilva A span should be ok because span is inline element. So maybe you can use a span instead of a div?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.
lol! i think you're right, let me test in the html validator.
The validator will tell you the same 
forget it, i think that was only a rule on XHTML Strict DOCTYPE or something. You can have block level inside tables.
Anyhow this solves the space problem.
I have tested this item 
successfully on eb0cb0a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.
I think it is more a question of css then p or div tag. P seems to me semantic more correct.
yes, true. was mistaken reggarding HTML block elements as said.
i think div or span or a simple br (when no css classes) is used most of the times.
hum ... just noticed the same problem in featured articles ...
@richard67 just ignore me this time :-), I think there is not right or wrong here, if div's are used most of the time, then I can live with div's
ok will correct the featured articles too
| Title |
|
||||||
| Milestone |
Added: |
||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item successfully on eb0cb0a
thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.
I have tested this item successfully on eb0cb0a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-23 08:55:28 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on eb0cb0a
Good spot
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10050.