[#10042] - Regression: Solves searchtools filters bugs and regressions
- Fixed in Code Base
- 29 Apr 2016
- Medium
- Build: staging
- # 10042
- Diff
- andrepereiradasilva:hathor-searchtools-bugs
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Regression and several bugs.
Summary of Changes
With all the changes in searchtools some filters have a wrong input filtering. Some were caused by my PRs, and many other were already there.
Anyhow, most of this problems only manifests itself in hathor.
As you see from the code changes, besides the input filtering, there are a series of inconsistencies in the filters names (and other) that cause this bugs.
Testing Instructions
First test on isis to confirm they are all working properly:
- Use latest staging and apply this PR
- Go to "Users" -> "Manage" and test the "state" and "activated" filters
- Go to "Users" -> "User notes" and test the "state" filter
- Go to "Content" -> "Categories" and test the "access" and the "language" filter (the "All" value in particular).
- Go to "Components" -> "Banners" -> "Banners" and test the "state" filter.
- Go to "Components" -> "Banners" -> "Tracks" and test the "type", the "client" and "category" filter.
- Go to "Components" -> "Contacts" -> "Contacts" and test the "access" and the "language" filter (the "All" value in particular).
- Go to "Components" -> "Newsfeeds" -> "Newsfeeds" and test the "category id", "access" and the "language" filter (the "All" value in particular).
- Go to "Extensions" -> "Modules" and test the "state" (the "All" value in particular) "language" filter (the "All" value in particular).
- Go to "Extensions" -> "Plugins" and test the "status" filter.
- Go to "Extensions" -> "Languages" -> "Content Languages" and test the "state" filter (the "All" value in particular).
- Go to "Extensions" -> "Manage" -> "Manage" and test all the filters.
Now change the template to hathor and do the same tests.
Notes:
- In the tests above i only say to test the filters i corrected, but if you find more problems with filters please report.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
brianteeman
- | Category | ⇒ | Components UI/UX |
I have now tested all filters in isis, will continue in hathor now.
I don't understand the "All" filter options as we have the "- Select [...] -" option, but there will be reasons for it :).
thanks
I don't understand the "All" filter options as we have the "- Select [...] -" option, but there will be reasons for it :).
i think the "All" is because is the only way to show published, unpublished, archived and trashed in the same list. The - Select [...] - (primary view) doesn't show the archived and trashed ones.
In hathor template, the view "Users" -> "Manage" has another search tools style than other views. Is this wanted behaviour?
In hathor template, the view "Users" -> "Manage" has another search tools style than other views. Is this wanted behaviour?
That was like that before. I didn't change styles. just corrected the behaviour of the filters.
ok, thanks for explanations.
I have tested this item 
successfully on 6df728d
The inconsistencies I described above are not part of this pr.
I didn't find further problems with filters.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10042.
@andrepereiradasilva
Please, to ease testing, could you specify which Search Tools issues it solves in Isis only.
Hum. I think only this two:
- Go to "Users" -> "User notes" and test the "state" filter
- Go to "Components" -> "Banners" -> "Banners" and test the "state" filter.
but the propose of the test is also to validate that the changes made to work properly on hathor don't affect isis.
Hmm, I don't see any error before patch for these 2 Status filters in Isis
To see the bug do this: have user notes/banners in every state (Published, Unpublished, Trash, Archived).
Log out and login and go there. Result:
In other words, by default, is showing all states and should only show published and unpublished.
I have tested this item successfully on 6df728d
Users: Search OK but clicking on the Enabled icon in Hathor does not work (I guess for another PR).
For the rest, looks Ok.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10042.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit | ||||
| Title |
|
||||||
RTC, for 3.5.2
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10042.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-29 14:48:51 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
thanks for testing @infograf768
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@brianteeman please test this as it solves many issues with the filters.