[#10029] - [com_finder] filters view: searchtools ordering, bug corrections and some improvements
- Fixed in Code Base
- 29 Apr 2016
- Medium
- Build: staging
- # 10029
- Diff
- andrepereiradasilva:com_finder-filters-searchtools
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR by adding the ordering normalizes the searchtools in com_finder filters view.
Also:
- Corrects some minor bugs
- Some code style improvements.
Before PR
After PR
Testing Instructions
- Use latest staging and apply patch
- Go to Components -> Smart Search -> Filters
- Create some filters
- Test if search, filters, ordering and page limit (aka searchtools) are working properly.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
This PR has received new commits.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
| Category | ⇒ | Components UI/UX |
| Labels | |||
| Labels | |||
| Title |
|
||||||
Would it not be consistent to move the message that Smart Search content plugin is not enabled to above the filters?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
yes it will and it will be done in another PR.
this PR is only for the smart search filters view (Smart Search: Search Filters).
OK I thought in the past you did it as a single PR. My mistake.
no smart search has many things to correct. i will do one PR for each view.
I have tested this item 
successfully on 2b4ceb2
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
@brianteeman just corrected a state filter problem. wasn't working properly in hathor. See (9855e85)
To test this change just test the "state" filter in isis and in hathor.
I found similar problem in other filters in hathor. will make a PR to solve them.
no, not related.
This is because the filter input is too restrictive. 'int' doesn't allow empty values, only int. The same problem in happing to languages. All is *, but the input filter is cmd that doesn't allow *.
As said i will make a PR to correct them.
OK - I was hoping it was and we could kill two birds with one PR
I have tested this item successfully on 9855e85
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
@brianteeman @grhcj thanks for testing!
| Labels | |||
| Category | Components UI/UX | ⇒ | Components Language & Strings UI/UX |
I have tested this item successfully on 9855e85
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-29 21:13:35 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
This PR has received new commits.
CC: @andrepereiradasilva
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10029.