? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Apr 2016

The indented alignment of the module titles really bugs me

Summary of Changes

Before

before

After

after

Testing Instructions

avatar brianteeman brianteeman - open - 20 Apr 2016
avatar brianteeman brianteeman - change - 20 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 20 Apr 2016
Category Templates (admin)
avatar brianteeman brianteeman - change - 20 Apr 2016
Labels
Easy No Yes
avatar andrepereiradasilva
andrepereiradasilva - comment - 20 Apr 2016

bulk redirrect language strings?

avatar brianteeman
brianteeman - comment - 20 Apr 2016

Oops they shouldn't be there. I will check and fix in the morning

avatar brianteeman
brianteeman - comment - 21 Apr 2016

@andrepereiradasilva fixed the PR to remove the language string changes

avatar andrepereiradasilva andrepereiradasilva - test_item - 21 Apr 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Apr 2016

I have tested this item :white_check_mark: successfully on 8d02eab

Now only left to normalize the dates and column widths (logged in users is different).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10018.

avatar brianteeman
brianteeman - comment - 21 Apr 2016

I will do logged in users in a different PR

On 21 April 2016 at 11:14, andrepereiradasilva notifications@github.com
wrote:

I have tested this item [image: :white_check_mark:] successfully on
8d02eab
8d02eab

Now only left to normalize the dates and column widths (logged in users is

different).

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10018
https://issues.joomla.org/tracker/joomla-cms/10018.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10018 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Apr 2016

brian i noticed in your css changes that tou're changng modal classes and prototstar? something is not correct.

avatar brianteeman
brianteeman - comment - 21 Apr 2016

I changed one line in the less and then ran generatesss.php

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Apr 2016

so something has merged with running generatecss ...

avatar brianteeman
brianteeman - comment - 21 Apr 2016

Probably means a previous update was not done correctly. Most likely
someone manually edited the less and CSS files

avatar andrepereiradasilva
andrepereiradasilva - comment - 21 Apr 2016

or it can be your joomla is not the latest staging

avatar brianteeman
brianteeman - comment - 22 Apr 2016

I just double checked on a completely new and 100% up to date branch and the generatess.php results are exactly the same as here so some earlier PR did not do it correctly

avatar richard67 richard67 - test_item - 22 Apr 2016 - Tested successfully
avatar richard67
richard67 - comment - 22 Apr 2016

I have tested this item :white_check_mark: successfully on 8d02eab

Looks much better indeed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10018.

avatar brianteeman brianteeman - change - 22 Apr 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 22 Apr 2016

I am making this RTC - maintainer please see my comments above about the css and less files. the problem is not with this PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10018.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Apr 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 22 Apr 2016

could it that with this change brianteeman@477863c the less file wasn't changed? Going to merge it anyway.

avatar rdeutz rdeutz - reference | dc81709 - 22 Apr 16
avatar rdeutz rdeutz - merge - 22 Apr 2016
avatar rdeutz rdeutz - close - 22 Apr 2016
avatar rdeutz rdeutz - change - 22 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-22 19:25:06
Closed_By rdeutz
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Apr 2016

hey, don't blaim me :smile: i think did it in the less to https://github.com/joomla/joomla-cms/pull/9703/files

avatar joomla-cms-bot joomla-cms-bot - change - 22 Apr 2016
Labels Removed: ?
avatar brianteeman brianteeman - head_ref_deleted - 23 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment