User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Category | ⇒ | Templates (admin) |
Labels | |||
Easy | No | ⇒ | Yes |
Oops they shouldn't be there. I will check and fix in the morning
@andrepereiradasilva fixed the PR to remove the language string changes
I have tested this item successfully on 8d02eab
Now only left to normalize the dates and column widths (logged in users is different).
I will do logged in users in a different PR
On 21 April 2016 at 11:14, andrepereiradasilva notifications@github.com
wrote:
I have tested this item [image: ] successfully on
8d02eab
8d02eabNow only left to normalize the dates and column widths (logged in users is
different).
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10018
https://issues.joomla.org/tracker/joomla-cms/10018.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10018 (comment)
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
brian i noticed in your css changes that tou're changng modal classes and prototstar? something is not correct.
I changed one line in the less and then ran generatesss.php
so something has merged with running generatecss ...
Probably means a previous update was not done correctly. Most likely
someone manually edited the less and CSS files
or it can be your joomla is not the latest staging
I just double checked on a completely new and 100% up to date branch and the generatess.php results are exactly the same as here so some earlier PR did not do it correctly
I have tested this item successfully on 8d02eab
Looks much better indeed.
Status | Pending | ⇒ | Ready to Commit |
Labels |
I am making this RTC - maintainer please see my comments above about the css and less files. the problem is not with this PR
Labels |
Added:
?
|
Milestone |
Added: |
could it that with this change brianteeman@477863c the less file wasn't changed? Going to merge it anyway.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-22 19:25:06 |
Closed_By | ⇒ | rdeutz |
hey, don't blaim me i think did it in the less to https://github.com/joomla/joomla-cms/pull/9703/files
Labels |
Removed:
?
|
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
bulk redirrect language strings?