[#10009] - [com_banners] tracks view: Add max level filter
- Fixed in Code Base
- 2 May 2016
- Medium
- Build: staging
- # 10009
- Diff
- andrepereiradasilva:com_banner_tracks-maxlevel-filter
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
All backend views that are or are associated with tree like structures (e.g. menus, categories) should have a max level filter.
This is valid currently for:
- com_menus items view
- com_content articles view
- com_content featured view
- com_tags tags view
So, this PR is a part of series of PR to add that filter in the views that use categories:
- com_contacts contacts view (RTC #9975)
- com_banners banners view (RTC #9977)
- com_newsfeeds newsfeeds view (RTC #9978)
- com_notes notes view (RTC #9984)
- com_banners tracks view (this PR)
Testing Instructions
- Use latest staging and apply this patch
- Create some banners categories with at least two levels
- Create some banners and associate them to the categories created in 2..
- Go to "Components" -> "Banners" -> "Tracks" (ensure you have some tracks, see note below) and test the new max levels filter.
Note: If you don't have tracks records you can generate some in the database (#__banners_tracks table), example:
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-04-11 00:00:00', '1', '1', '5');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-01-11 00:00:00', '2', '1', '7');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2015-04-11 00:00:00', '2', '2', '9');
INSERT INTO `<prefix>_banner_tracks` (`track_date`, `track_type`, `banner_id`, `count`) VALUES ('2016-02-11 00:00:00', '2', '2', '12');| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
ups, sorry done
I have tested this item 
successfully on 1f3576e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
| Category | ⇒ | Components UI/UX |
@andrepereiradasilva With the patch applied I see these 2 green fields for begin and end date, in addition to those at the top where I could adjust the dates. Without the patch, I do not see these green fields.
Question: 1. Is this intended, and 2. what are those fields good for? When I click the calendar button right beside one of these green fields, nothing happens.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
I have tested this item successfully on 1f3576e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
technically this is a new feature and it doesn't fix a bug so it has to go into 3.6.0
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@andrepereiradasilva cloud you please check the merge conflicts, thanks
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10009.
finnaly, all conflicts fixed
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-02 11:12:05 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
@andrepereiradasilva Please corect last inset for
<prefix>_banner_tracks