[#10007] - [com_users] debuguser view: Implement searchtools
- Fixed in Code Base
- 23 Apr 2016
- Medium
- Build: staging
- # 10007
- Diff
- andrepereiradasilva:com_users_debuguser-searchtools
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
This PR, like already done in most views across Joomla admin panel, implements searchtools in com_users debuguser view.
Before PR
After PR
Testing Instructions
- Apply this patch in latest staging
- Have debug setting set to Yes in global config
- Go to Users -> Manage
- Click the button "Debug Permissions Report" in any user
- In the "Debug Permissions Report" page, test if search, filters, ordering and page limity (aka searchtools) are working properly
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Components Language & Strings Unit Tests |
| Labels | |||
| Labels | |||
| Category | Components Language & Strings Unit Tests | ⇒ | Components Language & Strings UI/UX |
| Labels | |||
I have tested this item 
unsuccessfully on 043c2bb
Hmm, pagination seems not really to work anymore when the patch is applied.
When I limit number of rows per page, w.g. to 10, and then click on a particular page linke, e.g. for page 4, the page reloads but still shows the 1st page after reload.
Also forward backward links or begin end links do not work.
Without the patch it works.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
Hmm, after having tested the next PR 10008, I thought I test this one again, and then it pagination worked well until I changed the number of items per page from 20 to 10, then it did not work anymore.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
For PR 10008, which is a similar change, paging always works, i.e. the problem which made me set the test result to failed here seems not to exist there.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
ok will check that richard
Just tested again with absolutely latest staging, problem with paging still remains.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
@richard67 I have 6 users on two pages (limit5) and i dont see any pagination issue
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
@brianteeman You talk about the users list? Here we are dealing with the debuguser view, i.e. list of all permissions for a selected user. Should be much more than 2 pages for 1 user when having list limit 5.
Doh - sorry - too late for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
just fixed conflicts for now
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
@richard67 all should be solved now.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
This PR has received new commits.
CC: @andrepereiradasilva, @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
All good now. Had to fix conflicts after latest merge.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
Set back to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
| Labels |
Added:
?
|
||
this one wasn't yet RTC, was waiting @richard67 test.
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
I have tested this item 
successfully on 347cfd1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
| Labels |
Removed:
?
|
||
@brianteeman In GitHub this PR still has RTC label. So either remove it ... or test the PR again 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
3.5.2 as the debuggroup PR (already merged)?
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-23 18:55:30 |
| Closed_By | ⇒ | rdeutz |
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
| Labels |
Removed:
?
|
||
I have tested this item
successfully on 043c2bb
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10007.