Kyle,

Can you please make a patch and post it in the joomlacode tracker since that is where the jbs looks for patches to test. Currently all commits are to be done via that route not by pull requests (though we all hope that is coming soon).

Thanks.

Elin

Do you know who's making the call on how to process direct pull requests? I understand the JBS workflow needs to be taken into account, but from the contributor side of things, it's sooo much easier to handle.

Speak with Mark.

Please post on joomlacode tracker. Closing request.

Hey all
Dang I'm so sorry, I wasn't getting my Github message notifications. From my understanding Github is now the main repo. Are we still required to go thru the joomlacode tracker?

Yes, for now the JBS keeps working with patches (svn style patch mind you). Only change is that the gibhup repro is now the point of truth.

To my knowledge we can use pull requests for feature patches, we're just not supposed to use them for issue stuff.

One question..
Could we make a branch and submit the resulting diff link to the tracker ? this would ease the process (I think)..
I did this for tracker #27287 and it seems to work (committers satisfied), even with a git style patch ;)

I guess most of the time that should be fine. I usually just do a git diff --no-prefix to be save. Isn't really any slower either ;)

What I mean is the diff link to the diff that is auto generated by GitHub.
e.g.: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix.diff
which comes from: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix
This would not include any history and such, but could be an interim solution until the committers feel comfortable with merging pull request (hopefully soonish)

Ah sorry misunderstood you. Well just try how well it works ;)

As far as I understand it the problem isn't really merging pull requests, it's testing them. And that is kinda painful, especially when you're not used to remotes and stuff.

Testing patches ?
Well, this project deserves more attention (IMHO) https://github.com/ianmacl/patchtester

The point IMHO is not only testing a patch.
It is proposing modifications including important ones to be tested
for the same tracker/feature.
Proposals in github (comments incode. etc.) are just not fitting our needs.

NOTE: Concerning applying git-made .diff files using eclipse to an
SVN check-out, one has to simply set
"Ignore leading path name segements"
to 1

JM

Testing patches ?
Well, this project deserves more attention (IMHO)
https://github.com/ianmacl/patchtester

---

Reply to this email directly or view it on GitHub:
#5 (comment)

Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not
disclose or use the information contained in this e-mail if you are
not the
intended recipient. If you have received this e-mail in error, please

notify us immediately and delete the e-mail and all copies.

Jean-Marie Simonet / infograf768
Joomla Production Working group
Joomla! Translation Coordination Team