Joomla! Issue Tracker | Joomla! CMS #255 - [#28754] $route is already being converted to SEF by JRoute::

Closed
25 May 2014
Medium
Build: master
# 255
Diff
okonomiyaki3000:mod_finder-do-not-need-Itemid
Foreign ID 28754

Pending

User tests: Successful: Unsuccessful:

okonomiyaki3000
27 Jun 2012

...Item id, it will be implicit in the URI, not part of the query string. So we don't need to care about it.

Also, prefer array implosion to string concatenation.

fix for this:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28754

okonomiyaki3000 - open - 27 Jun 2012

okonomiyaki3000 - comment - 15 Nov 2012

Rebased with the latest master.

okonomiyaki3000 - comment - 21 Jan 2013

I updated the explanation on joomlacode.org because I'm not sure I've described the nature of this bug very well. I'm still not confident that it can be easily understood so please let me know if there's any part of it that's still unclear.

okonomiyaki3000 - reference | - 12 Aug 13

okonomiyaki3000 - reference | - 30 Sep 13

okonomiyaki3000 - reference | - 2 Oct 13

okonomiyaki3000 - reference | - 15 Oct 13

okonomiyaki3000 - reference | - 18 Oct 13

okonomiyaki3000 - reference | - 23 Oct 13

okonomiyaki3000 - reference | - 6 Nov 13

okonomiyaki3000 - reference | - 27 Nov 13

Hackwar - comment - 3 Mar 2014

can you remove the changes to the other 2 files, so simply changing the helper.php in this PR? The other 2 files only confuse the real change here and I'd like to get this solved as soon as possible. In any case: Good find.

okonomiyaki3000 - comment - 3 Mar 2014

Awesome! Will do it tomorrow.

okonomiyaki3000 - change - 4 Mar 2014

Title

…

$route is already being converted to SEF by JRoute::_(), if there is an ...

[#28754] $route is already being converted to SEF by JRoute::_(), if there is an ...

okonomiyaki3000 - reference | - 4 Mar 14

okonomiyaki3000 - comment - 4 Mar 2014

Done. And here too #2103

Hackwar - comment - 9 Mar 2014

This is set to RTC in JCode.
You may blame the J!Tracker Application for transmitting this comment.

okonomiyaki3000 - reference | - 18 Apr 14

okonomiyaki3000 - comment - 18 Apr 2014

Rebased to fix a merge conflict.

Hackwar - comment - 18 Apr 2014

nope, something is wrong here. There is lots more stuff now in this PR than initially. Please revert that rebase.

okonomiyaki3000 - comment - 18 Apr 2014

Ah... could it be because this PR is to master and I rebased with staging? D'oh!

okonomiyaki3000 - comment - 21 Apr 2014

So, how about if I just close this PR and resubmit the changes to staging? isn't that better?

okonomiyaki3000 - reference | - 21 Apr 14

okonomiyaki3000 - comment - 21 Apr 2014

OK, fixed it. Just needed to rebase with master (which is ahead of staging?) but I also put in a PR for staging so please pick one and I'll cancel the other.