[#66] - Use tabs insted of spaces
- Closed
- 27 Jun 2015
- Medium
- Build: master
- # 66
- Diff
- zero-24:codestyle
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This let the tests follow the codestyle
| Labels |
Added:
?
|
||
YAML has to use spaces for indentions. There's no changing that, that's how the format works. The PHP code though in theory should be able to match our codestyle unless it's explicitly looking for spaces in places.
Thanks @mbabker I have revertet the change in the non php files. Lets wait and see what tavis say about it: https://travis-ci.org/joomla-extensions/weblinks/builds/66385903
@javigomez the first tests passed now. Can you review it again? Thanks 
looking good but see, we still have challenges with the coding style like https://docs.joomla.org/Testing_Joomla_Extensions_with_Codeception#Do_not_leave_spaces_between_parameters_in_Cepts
I suggest that we are not strict for the moment with the Code style in the tests files, following anyway as much as we can the joomla standards.
:facepalm: Gotta love when code dictates a specific style 
Closing since it breaks travis:
Actually we need to debate what to do with code style in tests files. At some point we should remove tests files from Code Style checker since the Codeception framework uses different code style standards for its files.