Feeling Lucky
[#434] - Fix PHP warnings
- Fixed in Code Base
- 18 Aug 2021
- Medium
- Build: master
- # 434
- Diff
- Harmageddon:patch-1
User tests: Successful: Unsuccessful:
Similar to joomla/joomla-cms#27273
Fixes #433.
Summary of Changes
This PR fixes PHP warnings for the weblinks category view.
Testing Instructions
- Create a category view.
- Add some weblinks
- Enable tags for this view.
- Look at the page in frontend.
Expected result
No PHP warnings
Actual result
Two times "Warning: Creating default object from empty value"
Documentation Changes Required
joomdonation
- comment
- 18 Aug 2021
Thanks @Harmageddon for your PR. I fixed the issue but we can improve the code abit to save the system from having to query tags data for weblink again. I made commit directly in your PR, hope that is OK
With patch applied, the issue is sorted and tags are being displayed as expected, so this PR works and I'm going to merge it.
Thanks
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-18 08:40:49 |
| Closed_By | ⇒ | joomdonation |
Harmageddon
- comment
- 18 Aug 2021
Thank you!
I have tested this item✅ successfully on 84ec6b9
changed to PHP 7.4.16
changed codes accordingly via FTP
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/434.